You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/09/05 03:19:20 UTC

Re: Review Request: Exposing files through http endpoints

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6617/#review11049
-----------------------------------------------------------


as a note, this doesn't work well with local runs since we don't generate an ID for the filesprocess

I'll go over this with ben, and the solution might be to:
-generate an ID using ID::generate("files")
-export the files id through the master/slave state json endpoints (so that we know how to construct the urls for reading files)
-it would be nice though to have ID::generate behave this way: "files", "files(1)", "files(2)", so that urls look nice on non-local clusters, this would clean up slave ids as well

- Ben Mahler


On Aug. 25, 2012, 12:30 a.m., Ben Mahler wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6617/
> -----------------------------------------------------------
> 
> (Updated Aug. 25, 2012, 12:30 a.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Vinod Kone, and Jie Yu.
> 
> 
> Description
> -------
> 
> Implementing the file abstraction and http endpoints for file reading / browsing.
> 
> 
> This addresses bug MESOS-255.
>     https://issues.apache.org/jira/browse/MESOS-255
> 
> 
> Diffs
> -----
> 
>   src/Makefile.am aaceee3 
>   src/files/files.hpp d0cab91 
>   src/files/files.cpp d4080d4 
>   src/logging/logging.cpp 6909b0b 
>   src/master/http.cpp c480bc6 
>   src/master/slaves_manager.cpp e25efd0 
>   src/slave/http.cpp a1f7926 
>   src/slave/slave.cpp 4efd41e 
>   src/tests/configurator_tests.cpp c2f5aa0 
>   src/tests/files_tests.cpp PRE-CREATION 
>   src/tests/utils.hpp 83d5daa 
>   src/webui/master/static/controllers.js 1606e64 
>   third_party/libprocess/include/process/http.hpp 8424ca6 
>   third_party/libprocess/include/process/io.hpp 6a40b18 
>   third_party/libprocess/include/stout/hashmap.hpp 51bdea0 
>   third_party/libprocess/include/stout/json.hpp 25dbcf4 
>   third_party/libprocess/include/stout/os.hpp b1eceb3 
>   third_party/libprocess/include/stout/path.hpp 80d9bc6 
>   third_party/libprocess/include/stout/stringify.hpp ad2f2fa 
>   third_party/libprocess/src/decoder.hpp 105fe5d 
>   third_party/libprocess/src/encoder.hpp ac4886e 
>   third_party/libprocess/src/process.cpp 2b2d521 
>   third_party/libprocess/src/statistics.cpp d05b327 
> 
> Diff: https://reviews.apache.org/r/6617/diff/
> 
> 
> Testing
> -------
> 
> Added files_tests.cpp
> make check
> 
> 
> Thanks,
> 
> Ben Mahler
> 
>