You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@perl.apache.org by Randy Kobes <ra...@theoryx5.uwinnipeg.ca> on 2003/06/29 16:11:22 UTC

[mp1] INSTALL_DLL on win32

At present, on mod_perl 1 on Win32 one must give
'perl Makefile.PL' an INSTALL_DLL argument to specify
where to install mod_perl.so, with no default assumed.
This diff (together with a note in INSTALL.win32):
=========================================================
Index: Makefile.PL
===================================================================
RCS file: /home/cvs/modperl/Makefile.PL,v
retrieving revision 1.213
diff -u -r1.213 Makefile.PL
--- Makefile.PL	5 Jun 2003 07:38:46 -0000	1.213
+++ Makefile.PL	29 Jun 2003 14:09:30 -0000
@@ -370,6 +370,10 @@
     (-d "$fixed_apsrc/src/include" ? $fixed_apsrc . '/src' :
      die "Cannot find the Apache include directory under $fixed_apsrc");
   $win32_auto = 1;
+  if (not defined $win32_args{INSTALL_DLL}) {
+    my $w32_ap_mod = $fixed_apsrc . '/modules';
+    $win32_args{INSTALL_DLL} = $w32_ap_mod if -d $w32_ap_mod;
+  }
 }

 my %very_experimental = map {$_,1}
@@ -1293,17 +1297,6 @@
 	FILES	=> "@do_clean",
     }
 );
-
-if ($Is_Win32) {
-  print <<'END';
-
-Beginning with version 1.3.15, Apache uses a different convention for
-Win32 module names. Correspondingly, the name of the mod_perl module
-built here has been changed from ApacheModulePerl.dll to mod_perl.so.
-Please see INSTALL.win32 for further details.
-
-END
-}

 print "*** BSDI users: be sure to read the INSTALL `Notes' section ***\n"
     if $Config{osname} =~ /bsdos/i;
Index: INSTALL.win32
===================================================================
RCS file: /home/cvs/modperl/INSTALL.win32,v
retrieving revision 1.8
diff -u -r1.8 INSTALL.win32
--- INSTALL.win32	9 Jul 2001 15:03:05 -0000	1.8
+++ INSTALL.win32	29 Jun 2003 14:09:30 -0000
@@ -108,7 +108,7 @@

 Generating the Makefile as, for example,

- perl Makefile.PL APACHE_SRC=..\apache_1.3.xx INSTALL_DLL=\Apache\modules
+ perl Makefile.PL APACHE_SRC=..\apache_1.3.xx

 will build mod_perl (including mod_perl.so) entirely from
 the command line. The arguments accepted include
@@ -120,13 +120,14 @@
 This can be one of two values: either the path to the Apache build
 directory (eg, ..\apache_1.3.xx), or to the installed Apache location
 (eg, \Apache). This is used to set the locations of ApacheCore.lib
-and the Apache header files.
+and the Apache header files. Also, mod_perl.so will be installed
+to APACHE_SRC\modules, if such a directory exists.

 =item INSTALL_DLL

 This gives the location of where to install mod_perl.so
-(eg, \Apache\modules). No default is assumed - if this argument
-is not given, mod_perl.so must be copied manually.
+(eg, \Apache\modules). If not given, a value of APACHE_SRC\modules
+will be used, if this directory exists.

 =item DEBUG

===================================================================
will use a default of APACHE_SRC/modules, if such a directory
exists.

The diff also removes printing out a message about
a name change from ApacheModulePerl.dll to mod_perl.so,
which is by now familiar. I thought here the message
may in fact confuse newer users who may not be aware
of the use of the older name.

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org


Re: [mp1] INSTALL_DLL on win32

Posted by "Philippe M. Chiasson" <go...@cpan.org>.
On Wed, 2003-07-02 at 22:15, Randy Kobes wrote:
> On Sun, 29 Jun 2003, Randy Kobes wrote:
> 
> > At present, on mod_perl 1 on Win32 one must give
> > 'perl Makefile.PL' an INSTALL_DLL argument to specify
> > where to install mod_perl.so, with no default assumed.
> > This diff (together with a note in INSTALL.win32):
> [ .. ]
> Just wondering if anyone would have an objection to
> including the above change? If not, I'll commit it ...

Since I am not running mod_perl on win32 quite yet, I guess there
is nothing much I can say about it '=)

looking at the patch carefully did not scare me at all.

Looks good to me

Re: [mp1] INSTALL_DLL on win32

Posted by Randy Kobes <ra...@theoryx5.uwinnipeg.ca>.
On Sun, 29 Jun 2003, Randy Kobes wrote:

> At present, on mod_perl 1 on Win32 one must give
> 'perl Makefile.PL' an INSTALL_DLL argument to specify
> where to install mod_perl.so, with no default assumed.
> This diff (together with a note in INSTALL.win32):
[ .. ]
Just wondering if anyone would have an objection to
including the above change? If not, I'll commit it ...

-- 
best regards,
randy

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@perl.apache.org
For additional commands, e-mail: dev-help@perl.apache.org