You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@karaf.apache.org by ff...@apache.org on 2014/04/16 03:18:05 UTC

git commit: [KARAF-2913]JAAS JDBCBackingEngine has the wrong condition to iterate results, no users are returned (cherry picked from commit 5ae68719554dd13d72598ad18cef533518ab9cf4)

Repository: karaf
Updated Branches:
  refs/heads/karaf-3.0.x 39fe55632 -> bd0a2949f


[KARAF-2913]JAAS JDBCBackingEngine has the wrong condition to iterate results, no users are returned
(cherry picked from commit 5ae68719554dd13d72598ad18cef533518ab9cf4)


Project: http://git-wip-us.apache.org/repos/asf/karaf/repo
Commit: http://git-wip-us.apache.org/repos/asf/karaf/commit/bd0a2949
Tree: http://git-wip-us.apache.org/repos/asf/karaf/tree/bd0a2949
Diff: http://git-wip-us.apache.org/repos/asf/karaf/diff/bd0a2949

Branch: refs/heads/karaf-3.0.x
Commit: bd0a2949f576649dd57028c96da549248df19d3b
Parents: 39fe556
Author: Freeman Fang <fr...@gmail.com>
Authored: Wed Apr 16 09:16:47 2014 +0800
Committer: Freeman Fang <fr...@gmail.com>
Committed: Wed Apr 16 09:17:42 2014 +0800

----------------------------------------------------------------------
 .../org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java    | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/karaf/blob/bd0a2949/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
----------------------------------------------------------------------
diff --git a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
index 4bb15cf..9723de8 100644
--- a/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
+++ b/jaas/modules/src/main/java/org/apache/karaf/jaas/modules/jdbc/JDBCBackingEngine.java
@@ -192,7 +192,7 @@ public class JDBCBackingEngine implements BackingEngine {
                 //Remove from users
                 listUserStatement = connection.prepareStatement(selectUsersQuery);
                 usersResultSet = listUserStatement.executeQuery();
-                while (!usersResultSet.next()) {
+                while (usersResultSet.next()) {
                     String username = usersResultSet.getString("USERNAME");
                     users.add(new UserPrincipal(username));
                 }
@@ -242,7 +242,7 @@ public class JDBCBackingEngine implements BackingEngine {
 
                 rolesResultSet = listRolesStatement.executeQuery();
 
-                while (!rolesResultSet.next()) {
+                while (rolesResultSet.next()) {
                     String role = rolesResultSet.getString(1);
                     roles.add(new RolePrincipal(role));
                 }