You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "essobedo (via GitHub)" <gi...@apache.org> on 2023/04/03 14:12:39 UTC
[GitHub] [camel-quarkus] essobedo opened a new pull request, #4737: Ref #4447: java-joor-dsl - Improve the test coverage
essobedo opened a new pull request, #4737:
URL: https://github.com/apache/camel-quarkus/pull/4737
fixes #4447
## Motivation
We need to test more use cases in native mode.
## Modifications:
* Add support of anonymous classes
* Support RegisterForReflection for the current class
* Add more test cases
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo commented on a diff in pull request #4737: Ref #4447: java-joor-dsl - Improve the test coverage
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo commented on code in PR #4737:
URL: https://github.com/apache/camel-quarkus/pull/4737#discussion_r1156853776
##########
integration-tests/java-joor-dsl/src/main/java/org/apache/camel/quarkus/dsl/java/joor/JavaJoorDslResource.java:
##########
@@ -29,10 +31,12 @@
import org.apache.camel.ExtendedCamelContext;
import org.apache.camel.ProducerTemplate;
import org.apache.camel.Route;
+import org.apache.camel.component.direct.DirectEndpoint;
import org.apache.camel.dsl.java.joor.JavaRoutesBuilderLoader;
import org.apache.camel.quarkus.main.CamelMain;
import org.apache.camel.spi.RoutesBuilderLoader;
+@RegisterForReflection(targets = String.class)
Review Comment:
Good question/remark, it is needed to be able to call [`String#endsWith(String)`](https://github.com/apache/camel-quarkus/pull/4737/files#diff-97f7f2c0a7818c93c92fda67bdee1c0c759db70dd89dee26693183ca59705988R38) in a simple expression
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4737: Ref #4447: java-joor-dsl - Improve the test coverage
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4737:
URL: https://github.com/apache/camel-quarkus/pull/4737#discussion_r1156859638
##########
integration-tests/java-joor-dsl/src/main/java/org/apache/camel/quarkus/dsl/java/joor/JavaJoorDslResource.java:
##########
@@ -29,10 +31,12 @@
import org.apache.camel.ExtendedCamelContext;
import org.apache.camel.ProducerTemplate;
import org.apache.camel.Route;
+import org.apache.camel.component.direct.DirectEndpoint;
import org.apache.camel.dsl.java.joor.JavaRoutesBuilderLoader;
import org.apache.camel.quarkus.main.CamelMain;
import org.apache.camel.spi.RoutesBuilderLoader;
+@RegisterForReflection(targets = String.class)
Review Comment:
Thanks for clarifying!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] essobedo merged pull request #4737: Ref #4447: java-joor-dsl - Improve the test coverage
Posted by "essobedo (via GitHub)" <gi...@apache.org>.
essobedo merged PR #4737:
URL: https://github.com/apache/camel-quarkus/pull/4737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on a diff in pull request #4737: Ref #4447: java-joor-dsl - Improve the test coverage
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on code in PR #4737:
URL: https://github.com/apache/camel-quarkus/pull/4737#discussion_r1156833887
##########
integration-tests/java-joor-dsl/src/main/java/org/apache/camel/quarkus/dsl/java/joor/JavaJoorDslResource.java:
##########
@@ -29,10 +31,12 @@
import org.apache.camel.ExtendedCamelContext;
import org.apache.camel.ProducerTemplate;
import org.apache.camel.Route;
+import org.apache.camel.component.direct.DirectEndpoint;
import org.apache.camel.dsl.java.joor.JavaRoutesBuilderLoader;
import org.apache.camel.quarkus.main.CamelMain;
import org.apache.camel.spi.RoutesBuilderLoader;
+@RegisterForReflection(targets = String.class)
Review Comment:
Just curious - what requires reflective access to `String`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org