You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficcontrol.apache.org by GitBox <gi...@apache.org> on 2022/01/04 17:47:44 UTC

[GitHub] [trafficcontrol] jpappa200 commented on a change in pull request #6429: Collect config warnings and print a summary at the end of t3c apply

jpappa200 commented on a change in pull request #6429:
URL: https://github.com/apache/trafficcontrol/pull/6429#discussion_r778273894



##########
File path: cache-config/t3c-apply/torequest/torequest.go
##########
@@ -630,18 +633,40 @@ func (r *TrafficOpsReq) GetConfigFileList() error {
 		}
 
 		r.configFiles[file.Name] = &ConfigFile{
-			Name: file.Name,
-			Path: filepath.Join(file.Path, file.Name),
-			Dir:  file.Path,
-			Body: []byte(file.Text),
-			Uid:  atsUid,
-			Gid:  atsGid,
-			Perm: mode,
+			Name:     file.Name,
+			Path:     filepath.Join(file.Path, file.Name),
+			Dir:      file.Path,
+			Body:     []byte(file.Text),
+			Uid:      atsUid,
+			Gid:      atsGid,
+			Perm:     mode,
+			Warnings: file.Warnings,
+		}
+		for _, warn := range file.Warnings {
+			if warn == "" {
+				continue
+			}
+			if _, ok := r.configFileWarnings[file.Name]; ok {

Review comment:
       Check has been removed. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org