[GitHub] [netbeans-native-installers] lbruun commented on a diff in pull request #3: init build system for cleaner/launcher

[GitBox <gi...@apache.org>]

lbruun commented on code in PR #3:
URL: https://github.com/apache/netbeans-native-installers/pull/3#discussion_r1052452181


##########
src/main/cpp/launcher/windows/Makefile.mingw:
##########
@@ -16,5 +14,22 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-# 
 
+TMPFLD = ../../../../../target/tmp/
+OFLD = ../../../../../target/launcher/
+
+all: prepfolder nlw.exe
+
+prepfolder:
+	mkdir -p $(TMPFLD)
+	mkdir -p $(OFLD)
+
+clean:
+	rm -f *.res *.exe *.dll
+
+nlw.res: resources/res.rc
+	x86_64-w64-mingw32-windres -o$(TMPFLD)nlw.res -Ocoff resources/res.rc
+
+
+nlw.exe: nlw.res
+	x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/Main.c src/Launcher.c src/ExtractUtils.c src/FileUtils.c src/SystemUtils.c src/RegistryUtils.c src/ProcessUtils.c src/JavaUtils.c src/StringUtils.c -o$(OFLD)nlw.exe -static -lstdc++ -lcomctl32 -luserenv -static-libstdc++ -static-libgcc

Review Comment:
   Same question about 32 bit binaries



##########
src/main/cpp/cleaner/windows/Makefile.mingw:
##########
@@ -16,5 +14,18 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
-# 
 
+TMPFLD = ../../../../../target/tmp/
+OFLD = ../../../../../target/cleaner/
+
+all: prepfolder cleaner.exe
+
+prepfolder:
+	mkdir -p $(TMPFLD)
+	mkdir -p $(OFLD)
+
+clean:
+	rm -f *.res *.exe *.dll
+
+cleaner.exe: src/main.c
+	x86_64-w64-mingw32-gcc -s -DARCHITECTURE=64 -Wl,--nxcompat -Wl,--dynamicbase -Wl,--no-seh -Wl,--no-insert-timestamp -mwindows src/main.c -o$(OFLD)cleaner.exe -static -lstdc++ -static-libstdc++ -static-libgcc

Review Comment:
   Is it a conscious choice to drop support for 32-bit binaries?
   (I hope 32-bit binaries can be avoided, but just wanted to know if it it a conscious choice or not, to my knowledge 32-bit JRE/JDKs are still in active development for Java 17, at least by Azul and Adoptium)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists