You are viewing a plain text version of this content. The canonical link for it is here.
Posted to svn@forrest.apache.org by th...@apache.org on 2006/07/24 01:26:20 UTC
svn commit: r424855 [3/3] - in
/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo: ./
resources/stylesheets/ src/documentation/content/
src/documentation/content/svn-log/ src/documentation/content/xdocs/
Propchange: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/src/documentation/content/svn-log/log.svn.xml
------------------------------------------------------------------------------
svn:eol-style = native
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/src/documentation/content/xdocs/index.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/src/documentation/content/xdocs/index.xml?rev=424855&r1=424854&r2=424855&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/src/documentation/content/xdocs/index.xml (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/src/documentation/content/xdocs/index.xml Sun Jul 23 16:26:19 2006
@@ -47,6 +47,38 @@
</section>
<section>
+ <title>SVN Changes</title>
+ <p>You can generate as well the changes with svn. For this you need to
+ point forrest to the directory where the svn logs are. The defaut is
+ set to <code>{project:content}svn-log/</code> and you can change it by
+ setting <code>projectInfo.svn.log.dir</code> in your project
+ locationmap.</p>
+ <p>We created a log file for demonstration with the following command:</p>
+ <source>
+cd forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo
+svn log --xml -v . > src/documentation/content/svn-log/log.svn.xml</source>
+ <p>This file reflect all changes that have been done to this plugin. You
+ can see the result <a href="log.svn.html">log.svn.html</a>.</p>
+ <p>You see the only context we have definied is "code". This is
+ controlled by a mapper file. The defaut is set to
+ <code>{project:content}path-to-context.xml</code> and you can change it
+ by setting <code>projectInfo.svn.mapper</code> in your project
+ locationmap.</p>
+ <source><![CDATA[<paths>
+ <path context="Code">/forrest</path>
+</paths>]]></source>
+ <p>If the log file is growing, one is looking into splitting the file.
+ You can find out the revision number of the first and last commit of a
+ month within the log by requesting <a
+ href="log.svn-revison.xml">log.svn-revison.xml</a>.</p>
+ <p>We implemented as well a small svn cli output to generate log files
+ per month <a href="log.svn-sh.xml">log.svn-sh.xml</a>. The defaut url is set to
+ <code>http://svn.apache.org/repos/asf/forrest</code> and you can change it
+ by setting <code>project.svn.url</code> in your project
+ locationmap.</p>
+ </section>
+
+ <section>
<title>To Do List</title>
<p>The status.xml file can also be used to manage a list of todo items for
the community. For example, here is a
Modified: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml?rev=424855&r1=424854&r2=424855&view=diff
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml (original)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/status.xml Sun Jul 23 16:26:19 2006
@@ -52,6 +52,10 @@
<p>This plugin provides various mechanisms for extracting and
displaying information about one or more projects.</p>
</notes>
+ <action type="add" context="code" dev="TS" importance="high"> Add support
+ for svn log files. This let you extract changes based on a svn log
+ file. Further this provides some hady ways to find out the first and
+ last commit of a month and the generation of svn cli commands. </action>
<action type="add" context="code" dev="DC">
Enable optional release/introduction elements.
</action>
Added: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap?rev=424855&view=auto
==============================================================================
--- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap (added)
+++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap Sun Jul 23 16:26:19 2006
@@ -0,0 +1,65 @@
+<?xml version="1.0"?>
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<!-- svn helper
+ ***********************
+-->
+<map:sitemap xmlns:map="http://apache.org/cocoon/sitemap/1.0">
+ <map:components>
+ <map:pipes default="caching" />
+ <map:generators default="file" />
+ <map:transformers default="xslt" />
+ <map:serializers default="xml" />
+ </map:components>
+ <map:pipelines>
+ <map:pipeline>
+ <map:match pattern="*.svn.xml">
+ <map:aggregate element="svn">
+ <map:part src="{lm:projectInfo.svn.log.dir}{0}"/>
+ <map:part src="{lm:projectInfo.svn.mapper}"/>
+ </map:aggregate>
+ <map:transform src="resources/stylesheets/svn-to-changes.xsl" />
+ <map:transform src="{lm:projectInfo.transform.changes.document}" >
+ <map:parameter name="bugtracking-url" value="{defaults:bugtracking-url}"/>
+ <map:parameter name="path" value="{1}"/>
+ <map:parameter name="projectInfo.changes.sort" value="{project:projectInfo.changes.sort}"/>
+ <map:parameter name="projectInfo.changes.includeCommitterList" value="{project:projectInfo.changes.includeCommitterList}"/>
+ <map:parameter name="projectInfo.changes.includeContributorList" value="{project:projectInfo.changes.includeContributorList}"/>
+ </map:transform>
+ <map:serialize type="xml-document"/>
+ </map:match>
+ <map:match pattern="*.svn-revison.xml">
+ <map:generate src="{lm:projectInfo.svn.log.dir}{1}.svn.xml"/>
+ <map:transform src="resources/stylesheets/svn-to-revision.xsl" />
+ <map:transform src="resources/stylesheets/first-last-revision.xsl" />
+ <map:serialize type="xml"/>
+ </map:match>
+ <map:match pattern="*.svn-sh.xml">
+ <map:generate src="cocoon:/{1}.svn-revison.xml"/>
+ <map:transform src="resources/stylesheets/svn-log.xsl">
+ <map:parameter value="{lm:project.svn.url}" name="url"/>
+ <!--
+ If I use the following then I get:
+ Unable to get attribute value for projectInfo.svn.ext
+ -->
+ <!--<map:parameter value="{project:projectInfo.svn.ext}" name="test"/>-->
+ </map:transform>
+ <map:serialize type="text"/>
+ </map:match>
+ </map:pipeline>
+ </map:pipelines>
+</map:sitemap>
\ No newline at end of file
Propchange: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
------------------------------------------------------------------------------
svn:eol-style = native
Re: Problems with forrest.properties.xml
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 02/08/2006 22:56 Thorsten Scherler a écrit :
> El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
>
>> le 02/08/2006 14:50 Thorsten Scherler a écrit :
>>
>>> Hi all,
>>>
>>> can somebody explain me what I am doing wrong?
>>>
> ...
>
>>> I do not understand why {projectInfo.changes.includeCommitterList} is
>>> working and not {project:projectInfo.svn.ext}.
>>>
>>> Does somebody has a tip?
>>>
>>>
>> The only difference I can see is that
>> projectInfo.changes.includeCommitterList is aslo defined in the
>> default.plugin.properties.xml
>>
>> Cyriaque,
>>
>>> TIA
>>>
>
> Wow, Cyriaque, thank you very much. Well spotted.
>
> I only defined it for the projectInfo (on a project base), but not in
> default (if no project base can be found). Meaning as long a project has
> this property it is working fine.
>
> As soon a project does not provide this property and it is not added to
> the default.plugin.properties.xml the input module is throwing an
> exception. I tested on a new seed and not the plugin that is why never
> have seen it working till now where I tried again it on the projectInfo
> plugin.
>
> I added the property to the project forrest.properties.xml and it was
> working fine. As soon I removed it from there I got my error (after a
> restart). Then I added it to the default.plugin.properties.xml and it
> was working after a restart.
>
> Maybe we should change the module the way, that if a property can not
> found it should return "".
>
> wdyt?
>
I don't like this because - in your case - you have forgotten to define
a default value and then it does not work. The behaviour is clear.
If you return "", then it may work where as it shouldn't because you
should have defined a specific default value.
(I don't know if I am clear enough, I am a little tired today ;-) )
Cyriaque,
> ... or is this the bug, Ross?
>
> Further I do not like that the properties cannot be changed in run time
> (I guess caching?). The biggest benefit from a xml based properties
> system is that you change the properties with a form and after reload
> you see the new properties.
>
> How can we change this or better ask should we change it?
>
> salu2
>
Re: Problems with forrest.properties.xml
Posted by Ross Gardler <rg...@apache.org>.
Thorsten Scherler wrote:
> El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
>
>>le 02/08/2006 14:50 Thorsten Scherler a écrit :
>>
>>>Hi all,
>>>
>>>can somebody explain me what I am doing wrong?
>
> ...
>
>>>I do not understand why {projectInfo.changes.includeCommitterList} is
>>>working and not {project:projectInfo.svn.ext}.
>>>
>>>Does somebody has a tip?
>>>
>>
>>The only difference I can see is that
>>projectInfo.changes.includeCommitterList is aslo defined in the
>>default.plugin.properties.xml
>>
>>Cyriaque,
>>
>>>TIA
>
>
> Wow, Cyriaque, thank you very much. Well spotted.
>
> I only defined it for the projectInfo (on a project base), but not in
> default (if no project base can be found). Meaning as long a project has
> this property it is working fine.
>
> As soon a project does not provide this property and it is not added to
> the default.plugin.properties.xml the input module is throwing an
> exception. I tested on a new seed and not the plugin that is why never
> have seen it working till now where I tried again it on the projectInfo
> plugin.
>
> I added the property to the project forrest.properties.xml and it was
> working fine. As soon I removed it from there I got my error (after a
> restart). Then I added it to the default.plugin.properties.xml and it
> was working after a restart.
>
> Maybe we should change the module the way, that if a property can not
> found it should return "".
>
> wdyt?
>
> ... or is this the bug, Ross?
Let me see if I understand:
The error is only thrown if the property is not defined in either
forrest.properties.xml or default.plugin.properties.xml
If it is defined in one of these then no error occurs.
Assuming that this is correct then no this is not a bug.
Should we make it return an empty string if the property is not set?
I would say no. The reason being that default.forrest.properties.xml is
intended (at least by me) to be self documenting. If we leave a property
out then we lose that documentation.
> Further I do not like that the properties cannot be changed in run time
> (I guess caching?). The biggest benefit from a xml based properties
> system is that you change the properties with a form and after reload
> you see the new properties.
Agreed - http://issues.apache.org/jira/browse/FOR-737
> How can we change this or better ask should we change it?
It's not quite as simple as caching the values. There are massive
implications on performance so it should be configurable, have it turned
on during development, turn it of in deployment or a static build.
Ross
Re: Problems with forrest.properties.xml
Posted by Thorsten Scherler <th...@apache.org>.
El mié, 02-08-2006 a las 17:18 +0200, Cyriaque Dupoirieux escribió:
> le 02/08/2006 14:50 Thorsten Scherler a écrit :
> > Hi all,
> >
> > can somebody explain me what I am doing wrong?
...
> >
> > I do not understand why {projectInfo.changes.includeCommitterList} is
> > working and not {project:projectInfo.svn.ext}.
> >
> > Does somebody has a tip?
> >
> The only difference I can see is that
> projectInfo.changes.includeCommitterList is aslo defined in the
> default.plugin.properties.xml
>
> Cyriaque,
> > TIA
Wow, Cyriaque, thank you very much. Well spotted.
I only defined it for the projectInfo (on a project base), but not in
default (if no project base can be found). Meaning as long a project has
this property it is working fine.
As soon a project does not provide this property and it is not added to
the default.plugin.properties.xml the input module is throwing an
exception. I tested on a new seed and not the plugin that is why never
have seen it working till now where I tried again it on the projectInfo
plugin.
I added the property to the project forrest.properties.xml and it was
working fine. As soon I removed it from there I got my error (after a
restart). Then I added it to the default.plugin.properties.xml and it
was working after a restart.
Maybe we should change the module the way, that if a property can not
found it should return "".
wdyt?
... or is this the bug, Ross?
Further I do not like that the properties cannot be changed in run time
(I guess caching?). The biggest benefit from a xml based properties
system is that you change the properties with a form and after reload
you see the new properties.
How can we change this or better ask should we change it?
salu2
--
thorsten
"Together we stand, divided we fall!"
Hey you (Pink Floyd)
Re: Problems with forrest.properties.xml
Posted by Ross Gardler <rg...@apache.org>.
Cyriaque Dupoirieux wrote:
> le 02/08/2006 14:50 Thorsten Scherler a écrit :
>
...
>> I do not understand why {projectInfo.changes.includeCommitterList} is
>> working and not {project:projectInfo.svn.ext}.
>>
>> Does somebody has a tip?
>>
>
> The only difference I can see is that
> projectInfo.changes.includeCommitterList is aslo defined in the
> default.plugin.properties.xml
That shouldn't affect it, but it is worth a try. If it does affect
things please file a bug.
I can't think of any pointers, sorry.
Ross
Re: Problems with forrest.properties.xml
Posted by Cyriaque Dupoirieux <Cy...@pcotech.fr>.
le 02/08/2006 14:50 Thorsten Scherler a écrit :
> Hi all,
>
> can somebody explain me what I am doing wrong?
>
> ...
>
>> Added: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
>> URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap?rev=424855&view=auto
>> ==============================================================================
>> --- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap (added)
>> +++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap Sun Jul 23 16:26:19 2006
>> @@ -0,0 +1,65 @@
>>
> ...
>
>> + <map:match pattern="*.svn-sh.xml">
>> + <map:generate src="cocoon:/{1}.svn-revison.xml"/>
>> + <map:transform src="resources/stylesheets/svn-log.xsl">
>> + <map:parameter value="{lm:project.svn.url}" name="url"/>
>> + <!--
>> + If I use the following then I get:
>> + Unable to get attribute value for projectInfo.svn.ext
>> + -->
>> + <!--<map:parameter value="{project:projectInfo.svn.ext}" name="test"/>-->
>> + </map:transform>
>> + <map:serialize type="text"/>
>> + </map:match>
>> + </map:pipeline>
>> + </map:pipelines>
>> +</map:sitemap>
>> \ No newline at end of file
>>
>
> As soon as I want to use {project:projectInfo.svn.ext} then I get an
> exception. However I defined (in the same commit):
>
>
>
>> Modified:
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml
>> URL:
>> http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml?rev=424855&r1=424854&r2=424855&view=diff
>> ==============================================================================
>> ---
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml (original)
>> +++
>> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml Sun Jul 23 16:26:19 2006
>> @@ -31,4 +31,6 @@
>> <!-- Indicate if the committers list should be included. Values are
>> true
>> or false. -->
>> <property name="projectInfo.changes.includeCommitterList"
>> value="false"/>
>> +
>> + <property name="projectInfo.svn.ext" value=".svn.xml"/>
>> </properties>
>>
>
> I do not understand why {projectInfo.changes.includeCommitterList} is
> working and not {project:projectInfo.svn.ext}.
>
> Does somebody has a tip?
>
The only difference I can see is that
projectInfo.changes.includeCommitterList is aslo defined in the
default.plugin.properties.xml
Cyriaque,
> TIA
>
> salu2
>
Problems with forrest.properties.xml (was: Re: svn commit: r424855
[3/3])
Posted by Thorsten Scherler <th...@wyona.com>.
Hi all,
can somebody explain me what I am doing wrong?
...
> Added: forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap
> URL: http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap?rev=424855&view=auto
> ==============================================================================
> --- forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap (added)
> +++ forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/svnHelper.xmap Sun Jul 23 16:26:19 2006
> @@ -0,0 +1,65 @@
...
> + <map:match pattern="*.svn-sh.xml">
> + <map:generate src="cocoon:/{1}.svn-revison.xml"/>
> + <map:transform src="resources/stylesheets/svn-log.xsl">
> + <map:parameter value="{lm:project.svn.url}" name="url"/>
> + <!--
> + If I use the following then I get:
> + Unable to get attribute value for projectInfo.svn.ext
> + -->
> + <!--<map:parameter value="{project:projectInfo.svn.ext}" name="test"/>-->
> + </map:transform>
> + <map:serialize type="text"/>
> + </map:match>
> + </map:pipeline>
> + </map:pipelines>
> +</map:sitemap>
> \ No newline at end of file
As soon as I want to use {project:projectInfo.svn.ext} then I get an
exception. However I defined (in the same commit):
> Modified:
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml
> URL:
> http://svn.apache.org/viewvc/forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml?rev=424855&r1=424854&r2=424855&view=diff
> ==============================================================================
> ---
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml (original)
> +++
> forrest/trunk/plugins/org.apache.forrest.plugin.input.projectInfo/forrest.properties.xml Sun Jul 23 16:26:19 2006
> @@ -31,4 +31,6 @@
> <!-- Indicate if the committers list should be included. Values are
> true
> or false. -->
> <property name="projectInfo.changes.includeCommitterList"
> value="false"/>
> +
> + <property name="projectInfo.svn.ext" value=".svn.xml"/>
> </properties>
I do not understand why {projectInfo.changes.includeCommitterList} is
working and not {project:projectInfo.svn.ext}.
Does somebody has a tip?
TIA
salu2
--
Thorsten Scherler
COO Spain
Wyona Inc. - Open Source Content Management - Apache Lenya
http://www.wyona.com http://lenya.apache.org
thorsten.scherler@wyona.com thorsten@apache.org