You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by dongeforever <gi...@git.apache.org> on 2017/04/01 12:28:38 UTC

[GitHub] incubator-rocketmq pull request #87: [ROCKETMQ-161] Update runbroker.sh and ...

GitHub user dongeforever opened a pull request:

    https://github.com/apache/incubator-rocketmq/pull/87

    [ROCKETMQ-161] Update runbroker.sh and runserver.sh to support user defined jvm mem flag

    https://issues.apache.org/jira/browse/ROCKETMQ-161?filter=-1

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dongeforever/incubator-rocketmq ROCKETMQ-161

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-rocketmq/pull/87.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #87
    
----
commit 23e14efd07f0e68b52d139053f0c94043164efda
Author: dongeforever <zh...@yeah.net>
Date:   2017-04-01T12:26:36Z

    [ROCKETMQ-161] Update runbroker.sh and runserver.sh to support user defined jvm memory flag

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by netroby <gi...@git.apache.org>.

Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    http://stackoverflow.com/questions/229551/string-contains-in-bash


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by shroman <gi...@git.apache.org>.

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    Ok, but let's set it through `JVM_OPTS` instead of introducing a variable for that specific setting.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by vongosling <gi...@git.apache.org>.

Github user vongosling commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @shroman @lizhanhui Could you help us to review this long-time delayed PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by dongeforever <gi...@git.apache.org>.

Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    The intention is to make user-defined JVM flags to replace the initial ones. 
    So just put JAVA_OPT_EXT after JAVA_OPT is enough.
    The later defined JVM parameters will replace the previous ones. I have already tested it.
    
    @vsair @netroby @shroman  how do you think 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by shroman <gi...@git.apache.org>.

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @dongeforever I see, thank you!
    How about just changing the code to
    ```
    if [ -z "$JVM_OPTS" ] ; then
      #default_options
      JAVA_OPT="${JAVA_OPT} -server -Xms8g -Xmx8g -Xmn4g"
    fi
    ```
    ?
    But if you guys think we need `JAVA_OPT_EXT`, please go ahead ;)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by lizhanhui <gi...@git.apache.org>.

Github user lizhanhui commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    It's OK to introduce an extra variable to override default Java VM options.  
    
    +1 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by dongeforever <gi...@git.apache.org>.

Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @shroman In runbroker.sh and runserver.sh, some default options, such as -Xmx8g, are placed after the JVM_OPTS, so user-defined -Xmx will not take effect.
    
    And if we put JAVA_OPT_EXT after all default options, it will replace the default ones.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by shroman <gi...@git.apache.org>.

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @dongeforever Sorry, I don't think this modification is needed. A user will modify this file anyway in order to match his/her system requirements.
    
    Also, there are even more flags, and if you take this approach, you may have to add more variables for each in future, which will make the script tricky.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by dongeforever <gi...@git.apache.org>.

Github user dongeforever commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @shroman please help review and check it.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by shroman <gi...@git.apache.org>.

Github user shroman commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    @dongeforever Hmm, sorry I don't understand yet why `JAVA_OPTS` won't work. Can you please explain how/when it happens? :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by coveralls <gi...@git.apache.org>.

Github user coveralls commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    
    [![Coverage Status](https://coveralls.io/builds/11179187/badge)](https://coveralls.io/builds/11179187)
    
    Coverage decreased (-0.04%) to 34.591% when pulling **77e657f1addccedae4c21bc287d04fc2c9db71fd on dongeforever:ROCKETMQ-161** into **42f78c281cbeb5072b04eaf03b1a8059b8d281a7 on apache:develop**.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by netroby <gi...@git.apache.org>.

Github user netroby commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    +1 JVM_OPTS, Do not try to introducing new variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-rocketmq issue #87: [ROCKETMQ-161] Update runbroker.sh and runserv...

Posted by vsair <gi...@git.apache.org>.

Github user vsair commented on the issue:

    https://github.com/apache/incubator-rocketmq/pull/87
  
    When running in docker,  this would be useful.  Users just want to run a docker demo, but the computer could not allocate 8g memory, and there is no way to define the JVM flags in docker's script. OMG!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---