You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by "rzo1 (via GitHub)" <gi...@apache.org> on 2023/11/09 12:26:01 UTC
[PR] [STORM-3986] Get rid of BlacklistScheduler timer [INFO] logs (storm)
rzo1 opened a new pull request, #3597:
URL: https://github.com/apache/storm/pull/3597
## What is the purpose of the change
https://issues.apache.org/jira/projects/STORM/issues/STORM-3986
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3986] Get rid of BlacklistScheduler timer [INFO] logs (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 commented on code in PR #3597:
URL: https://github.com/apache/storm/pull/3597#discussion_r1387935644
##########
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java:
##########
@@ -194,7 +194,11 @@ private Set<String> refreshBlacklistedSupervisorIds(Cluster cluster, Topologies
new ArrayList<>(badSupervisorsToleranceSlidingWindow),
new ArrayList<>(sendAssignmentFailureCount),
cluster, topologies);
- LOG.info("Supervisors {} are blacklisted.", blacklistedSupervisors);
+ if (blacklistedSupervisors.isEmpty()) {
+ LOG.debug("No Supervisors are blacklisted.");
Review Comment:
Note: Didn't change the wording as proposed in the ticket because it would also require to change the package + name of the scheduler to be consistent ;-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3986] Get rid of BlacklistScheduler timer [INFO] logs (storm)
Posted by "avermeer (via GitHub)" <gi...@apache.org>.
avermeer commented on code in PR #3597:
URL: https://github.com/apache/storm/pull/3597#discussion_r1387937669
##########
storm-server/src/main/java/org/apache/storm/scheduler/blacklist/BlacklistScheduler.java:
##########
@@ -194,7 +194,11 @@ private Set<String> refreshBlacklistedSupervisorIds(Cluster cluster, Topologies
new ArrayList<>(badSupervisorsToleranceSlidingWindow),
new ArrayList<>(sendAssignmentFailureCount),
cluster, topologies);
- LOG.info("Supervisors {} are blacklisted.", blacklistedSupervisors);
+ if (blacklistedSupervisors.isEmpty()) {
+ LOG.debug("No Supervisors are blacklisted.");
Review Comment:
No big deal, let's consider it for post-Storm 2.6.0 release, and thanks for this fix!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [STORM-3986] Get rid of BlacklistScheduler timer [INFO] logs (storm)
Posted by "rzo1 (via GitHub)" <gi...@apache.org>.
rzo1 merged PR #3597:
URL: https://github.com/apache/storm/pull/3597
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@storm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org