[GitHub] [beam] lukecwik edited a comment on pull request #12617: [WIP][BEAM-10670] Update Samza to be opt-out for SplittableDoFn powering the Read transform.

[GitBox <gi...@apache.org>]

lukecwik edited a comment on pull request #12617:
URL: https://github.com/apache/beam/pull/12617#issuecomment-676523353


   > @lukecwik : Ke from samza side will help take a look. Thanks!
   
   @kw2542 If we want to support unbounded splittable DoFns using the non-portable execution then we'll need to support [GBKIntoKeyedWorkItem](https://github.com/apache/beam/blob/ecfc389838400721b2a0379a9655969eed3dbf57/runners/core-java/src/main/java/org/apache/beam/runners/core/SplittableParDoViaKeyedWorkItems.java#L79).
   
   I see that there is [KvToKeyedWorkItemOp](https://github.com/apache/beam/blob/master/runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/KvToKeyedWorkItemOp.java) but it doesn't output any timers that need to fire which is something that the underlying [splittable dofn implementation](https://github.com/apache/beam/blob/ecfc389838400721b2a0379a9655969eed3dbf57/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java#L235) is relying on. The timer firing seems to be done by [GroupByKeyOp](https://github.com/apache/beam/blob/ecfc389838400721b2a0379a9655969eed3dbf57/runners/samza/src/main/java/org/apache/beam/runners/samza/runtime/GroupByKeyOp.java#L225).
   
   Is this something you can help me with? (feel free to open PRs against [my repo](https://github.com/lukecwik/incubator-beam/tree/beam10670.3) and or provide suggestions on this PR)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org