You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/04/16 08:57:01 UTC
[GitHub] [maven-integration-testing] slawekjaranowski opened a new pull request, #151: [MNG-5222] Improvement in deprecated params detection
slawekjaranowski opened a new pull request, #151:
URL: https://github.com/apache/maven-integration-testing/pull/151
for https://github.com/apache/maven/pull/722
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #151: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151#discussion_r851620420
##########
core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/DeprecatedConfigMojo.java:
##########
@@ -47,6 +48,18 @@
@Parameter( defaultValue = "${basedir}", readonly = true )
private File basedir;
+ /**
+ * @deprecated bean read only
+ */
+ @Parameter( defaultValue = "${project.artifact}", readonly = true )
+ private Artifact deprecatedBeanReadOnly;
+
+ /**
+ * @deprecated bean
+ */
+ @Parameter( defaultValue = "${project.artifact}" )
+ private Artifact deprecatedBean;
Review Comment:
I don't see the corresponding test...
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5222MojoDeprecatedParamsTest.java:
##########
@@ -35,7 +35,7 @@
{
public MavenITmng5222MojoDeprecatedParamsTest()
{
- super( "[3.9.0,)" );
+ super( "[4.0.0-alpha-1,)" );
Review Comment:
Why back to 4 and not with 3.9?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #151: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151#discussion_r851624623
##########
core-it-suite/src/test/java/org/apache/maven/it/MavenITmng5222MojoDeprecatedParamsTest.java:
##########
@@ -35,7 +35,7 @@
{
public MavenITmng5222MojoDeprecatedParamsTest()
{
- super( "[3.9.0,)" );
+ super( "[4.0.0-alpha-1,)" );
Review Comment:
When this change will be merged with current fix to Maven master test on 3.9 will fail.
I will restore it with together cherry pick/port change to 3.9.x branch of Maven core.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski merged pull request #151: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] michael-o commented on a diff in pull request #151: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
michael-o commented on code in PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151#discussion_r851625439
##########
core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/DeprecatedConfigMojo.java:
##########
@@ -47,6 +48,18 @@
@Parameter( defaultValue = "${basedir}", readonly = true )
private File basedir;
+ /**
+ * @deprecated bean read only
+ */
+ @Parameter( defaultValue = "${project.artifact}", readonly = true )
+ private Artifact deprecatedBeanReadOnly;
+
+ /**
+ * @deprecated bean
+ */
+ @Parameter( defaultValue = "${project.artifact}" )
+ private Artifact deprecatedBean;
Review Comment:
I see, there is one space too much
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-integration-testing] slawekjaranowski commented on a diff in pull request #151: [MNG-5222] Improvement in deprecated params detection
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on code in PR #151:
URL: https://github.com/apache/maven-integration-testing/pull/151#discussion_r851624698
##########
core-it-support/core-it-plugins/maven-it-plugin-configuration/src/main/java/org/apache/maven/plugin/coreit/DeprecatedConfigMojo.java:
##########
@@ -47,6 +48,18 @@
@Parameter( defaultValue = "${basedir}", readonly = true )
private File basedir;
+ /**
+ * @deprecated bean read only
+ */
+ @Parameter( defaultValue = "${project.artifact}", readonly = true )
+ private Artifact deprecatedBeanReadOnly;
+
+ /**
+ * @deprecated bean
+ */
+ @Parameter( defaultValue = "${project.artifact}" )
+ private Artifact deprecatedBean;
Review Comment:
It is corner case when internal value, project object is used as property without read only flags.
Such parameter should not generated warning.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org