[GitHub] [skywalking-nginx-lua] moonming commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …

[GitBox <gi...@apache.org>]

moonming commented on a change in pull request #2: doc: emphasize that the finish should be called only when the output …
URL: https://github.com/apache/skywalking-nginx-lua/pull/2#discussion_r383613341
 
 

 ##########
 File path: README.md
 ##########
 @@ -48,7 +48,9 @@ http {
             proxy_pass http://127.0.0.1:8080/backend;
 
             body_filter_by_lua_block {
-                require("tracer"):finish()
+                if ngx.eof then
 
 Review comment:
   @spacewander is `ngx.eof` the same as `ngx.arg[2]`?  Is it a hidden variable? 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services