You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/24 06:04:42 UTC
[GitHub] [shardingsphere] codecov-commenter edited a comment on pull request #13763: support distinct aggregation and Optimized converterContext use threadLocal holder
codecov-commenter edited a comment on pull request #13763:
URL: https://github.com/apache/shardingsphere/pull/13763#issuecomment-977463236
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#13763](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (389bf16) into [master](https://codecov.io/gh/apache/shardingsphere/commit/aed44e6712ca985484aa3e0b2b0ed8f2eabc18cf?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aed44e6) will **decrease** coverage by `0.12%`.
> The diff coverage is `4.54%`.
> :exclamation: Current head 389bf16 differs from pull request most recent head 4fe9770. Consider uploading reports for the commit 4fe9770 to get more accurate results
[![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/13763/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #13763 +/- ##
============================================
- Coverage 63.51% 63.38% -0.13%
- Complexity 1702 1703 +1
============================================
Files 2754 2759 +5
Lines 41004 41098 +94
Branches 6994 7008 +14
============================================
+ Hits 26042 26050 +8
- Misses 12978 13064 +86
Partials 1984 1984
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...mize/converter/context/ConverterContextHolder.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9jb250ZXh0L0NvbnZlcnRlckNvbnRleHRIb2xkZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...verter/segment/expression/ExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vRXhwcmVzc2lvbkNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ter/segment/expression/impl/FunctionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9GdW5jdGlvbkNvbnZlcnRlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ssion/impl/ParameterMarkerExpressionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2V4cHJlc3Npb24vaW1wbC9QYXJhbWV0ZXJNYXJrZXJFeHByZXNzaW9uQ29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...ptimize/converter/segment/from/TableConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L2Zyb20vVGFibGVDb252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...erter/segment/projection/ProjectionsConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L3Byb2plY3Rpb24vUHJvamVjdGlvbnNDb252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...rojection/impl/AggregationProjectionConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zZWdtZW50L3Byb2plY3Rpb24vaW1wbC9BZ2dyZWdhdGlvblByb2plY3Rpb25Db252ZXJ0ZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [.../converter/statement/SelectStatementConverter.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtaW5mcmEvc2hhcmRpbmdzcGhlcmUtaW5mcmEtb3B0aW1pemUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2luZnJhL29wdGltaXplL2NvbnZlcnRlci9zdGF0ZW1lbnQvU2VsZWN0U3RhdGVtZW50Q29udmVydGVyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...sitor/statement/impl/MySQLStatementSQLVisitor.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci9zaGFyZGluZ3NwaGVyZS1zcWwtcGFyc2VyLWRpYWxlY3Qvc2hhcmRpbmdzcGhlcmUtc3FsLXBhcnNlci1teXNxbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvc3FsL3BhcnNlci9teXNxbC92aXNpdG9yL3N0YXRlbWVudC9pbXBsL015U1FMU3RhdGVtZW50U1FMVmlzaXRvci5qYXZh) | `84.36% <100.00%> (+0.06%)` | :arrow_up: |
| [.../core/executor/dumper/AbstractInventoryDumper.java](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9leGVjdXRvci9kdW1wZXIvQWJzdHJhY3RJbnZlbnRvcnlEdW1wZXIuamF2YQ==) | `80.39% <0.00%> (-7.85%)` | :arrow_down: |
| ... and [10 more](https://codecov.io/gh/apache/shardingsphere/pull/13763/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aed44e6...4fe9770](https://codecov.io/gh/apache/shardingsphere/pull/13763?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org