You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2018/11/12 10:31:16 UTC

[GitHub] spark pull request #22429: [SPARK-25440][SQL] Dumping query execution info t...

Github user HyukjinKwon commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22429#discussion_r232604420
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/limit.scala ---
    @@ -176,9 +176,9 @@ case class TakeOrderedAndProjectExec(
     
       override def outputPartitioning: Partitioning = SinglePartition
     
    -  override def simpleString: String = {
    -    val orderByString = Utils.truncatedString(sortOrder, "[", ",", "]")
    -    val outputString = Utils.truncatedString(output, "[", ",", "]")
    +  override def simpleString(maxFields: Option[Int]): String = {
    --- End diff --
    
    Can we just get rid of the `maxFields`? I think this makes the PR hard to read.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org