[GitHub] alanmcruickshank commented on a change in pull request #3740: Basic German Translation

[GitBox <gi...@apache.org>]

alanmcruickshank commented on a change in pull request #3740: Basic German Translation
URL: https://github.com/apache/incubator-superset/pull/3740#discussion_r147980937
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -154,14 +154,15 @@
 # Setup default language
 BABEL_DEFAULT_LOCALE = 'en'
 # Your application default translation path
-BABEL_DEFAULT_FOLDER = 'babel/translations'
+BABEL_DEFAULT_FOLDER = 'superset/translations'
 
 Review comment:
   Yeah I thought the same. It took me a while to set up my environment and this was one thing I changed of a few to get things working - so this change is not necessary. That being said there isn't a `babel/translations` path that I could see.
   
   I've just done a quick test and the translations work with either value.
   
   Vanilla FAB has the path as just `translations`
   https://github.com/dpgaspar/Flask-AppBuilder/blob/af095ac4094d068fa2dd467bd01fa8b95d697fc1/examples/quickfiles/config.py
   
   I suspect in our docs we always get people to specify the path as `superset/translations` in all the scripts for generating translations so even if the value we had before wasn't correct we were always overwriting it. I've done some quick testing and I actually suspect in most cases this line isn't used.
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services