You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by andrewor14 <gi...@git.apache.org> on 2016/05/12 00:33:27 UTC
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
GitHub user andrewor14 opened a pull request:
https://github.com/apache/spark/pull/13068
[SPARK-15279][SQL] Catch conflicting SerDe when creating table
## What changes were proposed in this pull request?
The user may do something like:
```
CREATE TABLE my_tab ROW FORMAT SERDE 'anything' STORED AS PARQUET
CREATE TABLE my_tab ROW FORMAT SERDE 'anything' STORED AS ... SERDE 'myserde'
CREATE TABLE my_tab ROW FORMAT DELIMITED ... STORED AS ORC
CREATE TABLE my_tab ROW FORMAT DELIMITED ... STORED AS ... SERDE 'myserde'
```
None of these should be allowed because the SerDe's conflict. As of this patch:
- `ROW FORMAT DELIMITED` is only compatible with `TEXTFILE`
- `ROW FORMAT SERDE` is only compatible with `TEXTFILE`, `RCFILE` and `SEQUENCEFILE`
## How was this patch tested?
New tests in `DDLCommandSuite`.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andrewor14/spark row-format-conflict
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/13068.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #13068
----
commit 796adc3407094b1a1e7adfc10690d3164e9453be
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-11T23:53:39Z
Throw exception on conflicting SerDes
commit 62c27f2f9a0dc516f3c4d39cad78c37532666764
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-12T00:21:20Z
Add more tests
commit bf6b23d6d840d97ecc9376b7937cd3f17e3a68e8
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-12T00:28:56Z
Clean up duplicate code a little
commit d4b5a32c6ee1ae1581b8f50ade984751ea4a3ca1
Author: Andrew Or <an...@databricks.com>
Date: 2016-05-12T00:30:24Z
Merge branch 'master' of github.com:apache/spark into row-format-conflict
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220747666
**[Test build #59042 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59042/consoleFull)** for PR 13068 at commit [`4589b6a`](https://github.com/apache/spark/commit/4589b6a3930f42ed9d3c52eb316d2ffd62766a89).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218670421
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58444/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218638049
**[Test build #58428 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58428/consoleFull)** for PR 13068 at commit [`4ffaf59`](https://github.com/apache/spark/commit/4ffaf59f48816caa85f7dcdf0a5660591e0829cf).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-221061972
m2.0
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218648903
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220730508
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218629819
**[Test build #58425 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58425/consoleFull)** for PR 13068 at commit [`bc2a7bd`](https://github.com/apache/spark/commit/bc2a7bd5f7118f0ff7fa8aa6bf689896db056ef3).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101012
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case "textfile" => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
--- End diff --
`ROW FORMAT DELIMITED` is only allowed to use with `textfile`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218648906
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58430/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63102608
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case "textfile" => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
--- End diff --
oh, sorry. I was thinking about what the error message should say.
Yea, the semantic is what we talked about.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218639816
**[Test build #58430 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58430/consoleFull)** for PR 13068 at commit [`7e02a0a`](https://github.com/apache/spark/commit/7e02a0accda4a0be924a621c683ea8e1d0fa484b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218638150
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218631674
**[Test build #58425 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58425/consoleFull)** for PR 13068 at commit [`bc2a7bd`](https://github.com/apache/spark/commit/bc2a7bd5f7118f0ff7fa8aa6bf689896db056ef3).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63100939
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
--- End diff --
Maybe we can say something like `Format ${ffGeneric.identifier} does not a user-specific SerDe`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220747739
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220728799
Thanks! LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101246
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
--- End diff --
(Maybe it is good to add a few examples to this?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218888783
@yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220723967
All comments have been addressed
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/13068
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220731093
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59034/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101807
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
--- End diff --
yeah, I like that actually! Hive doesn't support STORED AS serde too: https://cwiki.apache.org/confluence/display/Hive/LanguageManual+DDL
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220736877
**[Test build #59042 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59042/consoleFull)** for PR 13068 at commit [`4589b6a`](https://github.com/apache/spark/commit/4589b6a3930f42ed9d3c52eb316d2ffd62766a89).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220730509
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59027/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220747741
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/59042/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101442
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case "textfile" => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rf, ff) =>
+ // should never happen
+ throw operationNotAllowed(s"Unexpected combination of ROW FORMAT and $cff", parentCtx)
--- End diff --
cff is the nicely formatted string
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220731052
**[Test build #59034 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59034/consoleFull)** for PR 13068 at commit [`4589b6a`](https://github.com/apache/spark/commit/4589b6a3930f42ed9d3c52eb316d2ffd62766a89).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101396
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case "textfile" => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
--- End diff --
isn't that what we talked about?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218631695
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218670419
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63100741
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
--- End diff --
Maybe we can be explicit that `SERDE` is not allowed for this case? btw, should we remove `SERDE` part from `INPUTFORMAT inFmt=STRING OUTPUTFORMAT outFmt=STRING (SERDE serdeCls=STRING)?` in `SqlBase.g4`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220718799
**[Test build #59027 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59027/consoleFull)** for PR 13068 at commit [`5a1b2fa`](https://github.com/apache/spark/commit/5a1b2fa70991c7fbba0536df7b3363c9fb33a00e).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218638151
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58428/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by yhuai <gi...@git.apache.org>.
Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/13068#discussion_r63101198
--- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/SparkSqlParser.scala ---
@@ -941,6 +944,43 @@ class SparkSqlAstBuilder(conf: SQLConf) extends AstBuilder {
}
/**
+ * Throw a [[ParseException]] if the user specified incompatible SerDes through ROW FORMAT
+ * and STORED AS.
+ */
+ private def validateRowFormatFileFormat(
+ rowFormatCtx: RowFormatContext,
+ createFileFormatCtx: CreateFileFormatContext,
+ parentCtx: ParserRuleContext): Unit = {
+ if (rowFormatCtx == null || createFileFormatCtx == null) {
+ return
+ }
+ val cff = (0 until createFileFormatCtx.getChildCount)
+ .map { i => createFileFormatCtx.getChild(i).getText }
+ .mkString(" ")
+ (rowFormatCtx, createFileFormatCtx.fileFormat) match {
+ case (_, ffTable: TableFileFormatContext) =>
+ if (visitTableFileFormat(ffTable).serde.isDefined) {
+ throw operationNotAllowed(s"ROW FORMAT is not compatible with $cff", parentCtx)
+ }
+ case (rfSerde: RowFormatSerdeContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case ("sequencefile" | "textfile" | "rcfile") => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rfDelimited: RowFormatDelimitedContext, ffGeneric: GenericFileFormatContext) =>
+ ffGeneric.identifier.getText.toLowerCase match {
+ case "textfile" => // OK
+ case _ => throw operationNotAllowed(
+ s"ROW FORMAT SERDE is not compatible with $cff", parentCtx)
+ }
+ case (rf, ff) =>
+ // should never happen
+ throw operationNotAllowed(s"Unexpected combination of ROW FORMAT and $cff", parentCtx)
--- End diff --
Should we also print out `rf`? Is `ff` the same as `cff`?
(Maybe it is good to add a few examples at here?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218670295
**[Test build #58444 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58444/consoleFull)** for PR 13068 at commit [`7e02a0a`](https://github.com/apache/spark/commit/7e02a0accda4a0be924a621c683ea8e1d0fa484b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218633034
**[Test build #58428 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58428/consoleFull)** for PR 13068 at commit [`4ffaf59`](https://github.com/apache/spark/commit/4ffaf59f48816caa85f7dcdf0a5660591e0829cf).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220731092
Merged build finished. Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218631697
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/58425/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220736229
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218648818
**[Test build #58430 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58430/consoleFull)** for PR 13068 at commit [`7e02a0a`](https://github.com/apache/spark/commit/7e02a0accda4a0be924a621c683ea8e1d0fa484b).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220724594
**[Test build #59034 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59034/consoleFull)** for PR 13068 at commit [`4589b6a`](https://github.com/apache/spark/commit/4589b6a3930f42ed9d3c52eb316d2ffd62766a89).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-220730378
**[Test build #59027 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/59027/consoleFull)** for PR 13068 at commit [`5a1b2fa`](https://github.com/apache/spark/commit/5a1b2fa70991c7fbba0536df7b3363c9fb33a00e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218659953
**[Test build #58444 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/58444/consoleFull)** for PR 13068 at commit [`7e02a0a`](https://github.com/apache/spark/commit/7e02a0accda4a0be924a621c683ea8e1d0fa484b).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-15279][SQL] Catch conflicting SerDe whe...
Posted by andrewor14 <gi...@git.apache.org>.
Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/13068#issuecomment-218659856
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org