[jira] [Commented] (NIFI-9366) nifi-persistent-provenance-repository tests create unwanted provenance_repository directory in filesystem

["ASF subversion and git services (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-9366?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17458619#comment-17458619 ] 

ASF subversion and git services commented on NIFI-9366:
-------------------------------------------------------

Commit 79838fda5e46c855cf0e1afbc42217bb5966122d in nifi's branch refs/heads/support/nifi-1.15 from Chris Sampson
[ https://gitbox.apache.org/repos/asf?p=nifi.git;h=79838fd ]

NIFI-9366 prevent unwanted provenance_repository directory being created by nifi-persistent-provenance-repository tests
Clean upp temp provenance_repository after each test


> nifi-persistent-provenance-repository tests create unwanted provenance_repository directory in filesystem
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: NIFI-9366
>                 URL: https://issues.apache.org/jira/browse/NIFI-9366
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Core Framework
>    Affects Versions: 1.15.0
>            Reporter: Chris Sampson
>            Assignee: Chris Sampson
>            Priority: Trivial
>             Fix For: 1.16.0, 1.15.1
>
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Executing the tests within the {{nifi-persistent-provenance-repository}} results in an unwanted directory being created in the filesystem that could accidentally be committed to git:
> * {{nifi-nar-bundles/nifi-provenance-repository-bundle/nifi-persistent-provenance-repository/provenance_repository/}}
> This is caused by the Groovy-based test {{EncryptedWriteAheadProvenanceRepositoryTest#testShouldRegisterAndGetEvents}}, which doesn't override the default {{nifi.properties}} value for {{nifi.provenance.repository.directory.}} of {{provenance_repository}} - this results in the directory being created as indicated above. It would be better to locate the directory either in {{target/}} (therefore ignored by default in Git commits as part of the Maven build) or a Temp directory as done in {{#testWriteAheadProvenanceRepositoryShouldRegisterAndRetrieveEvents}} within the same Test class.



--
This message was sent by Atlassian Jira
(v8.20.1#820001)