You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2018/03/20 11:21:04 UTC

[GitHub] flink pull request #5701: [FLINK-8703][tests] Port SavepointMigrationTestBas...

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5701#discussion_r175729168
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/taskexecutor/TaskExecutor.java ---
    @@ -1515,8 +1516,22 @@ public void reportPayload(ResourceID resourceID, Void payload) {
     		}
     
     		@Override
    -		public CompletableFuture<Void> retrievePayload(ResourceID resourceID) {
    -			return CompletableFuture.completedFuture(null);
    +		public CompletableFuture<AccumulatorReport> retrievePayload(ResourceID resourceID) {
    --- End diff --
    
    Let's add `validateRunsInMainThread` as a first statement. That way we enforce that this method really runs in the main thread context.


---