[GitHub] [helix] i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue

[GitBox <gi...@apache.org>]

i3wangyi commented on a change in pull request #376: Add #batchGetInstancesStoppableChecks to solve performance issue
URL: https://github.com/apache/helix/pull/376#discussion_r311719298
 
 

 ##########
 File path: helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/InstancesAccessor.java
 ##########
 @@ -222,11 +220,6 @@ private Response getParallelStoppableInstances(String clusterId, JsonNode node)
       _logger
           .error(String.format("Current cluster %s has issue with health checks!", clusterId), e);
       throw new HelixHealthException(e);
-    } catch (Exception e) {
 
 Review comment:
   I will leave the exception clean up work later. I found the catch statement here only catches a generic exception, first I think it's unlikely to occur and usually, it's not a good idea to catch all exceptions. The developer needs to know what's the right checked exceptions to catch, exceptions like NPE, IllegalException are "unchecked" exceptions for a reason. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org