You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Mateen Mansoori <ma...@gmail.com> on 2022/06/20 06:44:06 UTC
Review Request 74031: RANGER-3797 : Not able to create security zone for solr service after upgrade
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74031/
-----------------------------------------------------------
Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3797
https://issues.apache.org/jira/browse/RANGER-3797
Repository: ranger
Description
-------
If solr service config contains no longer supported access types e.g - others, solr_admin then service/zone service creation will fail.
Added changes in java patch to handle upgrade case (Before upgrade If serivce config had others or solr_admin access types then removing and updating the service config during upgrade.)
Diffs
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 949967cd3
Diff: https://reviews.apache.org/r/74031/diff/1/
Testing
-------
Verified upgrade and checked able to create security zone.
Thanks,
Mateen Mansoori
Re: Review Request 74031: RANGER-3797 : Not able to create security zone for solr service after upgrade
Posted by bhavik patel <bh...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74031/#review224520
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 491 (patched)
<https://reviews.apache.org/r/74031/#comment313267>
Iterator is actually not required, you can use for loop to iterate the map
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java
Lines 505 (patched)
<https://reviews.apache.org/r/74031/#comment313268>
what if accessStr.length() = 0 ?
- bhavik patel
On June 20, 2022, 6:44 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74031/
> -----------------------------------------------------------
>
> (Updated June 20, 2022, 6:44 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3797
> https://issues.apache.org/jira/browse/RANGER-3797
>
>
> Repository: ranger
>
>
> Description
> -------
>
> If solr service config contains no longer supported access types e.g - others, solr_admin then service/zone service creation will fail.
>
> Added changes in java patch to handle upgrade case (Before upgrade If serivce config had others or solr_admin access types then removing and updating the service config during upgrade.)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 949967cd3
>
>
> Diff: https://reviews.apache.org/r/74031/diff/1/
>
>
> Testing
> -------
>
> Verified upgrade and checked able to create security zone.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 74031: RANGER-3797 : Not able to create security zone for solr service after upgrade
Posted by Pradeep Agrawal <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74031/#review224525
-----------------------------------------------------------
Ship it!
Ship It!
- Pradeep Agrawal
On June 21, 2022, 10:45 a.m., Mateen Mansoori wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/74031/
> -----------------------------------------------------------
>
> (Updated June 21, 2022, 10:45 a.m.)
>
>
> Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3797
> https://issues.apache.org/jira/browse/RANGER-3797
>
>
> Repository: ranger
>
>
> Description
> -------
>
> If solr service config contains no longer supported access types e.g - others, solr_admin then service/zone service creation will fail.
>
> Added changes in java patch to handle upgrade case (Before upgrade If serivce config had others or solr_admin access types then removing and updating the service config during upgrade.)
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 949967cd3
>
>
> Diff: https://reviews.apache.org/r/74031/diff/3/
>
>
> Testing
> -------
>
> Verified upgrade and checked able to create security zone.
>
>
> Thanks,
>
> Mateen Mansoori
>
>
Re: Review Request 74031: RANGER-3797 : Not able to create security zone for solr service after upgrade
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74031/
-----------------------------------------------------------
(Updated June 21, 2022, 10:45 a.m.)
Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3797
https://issues.apache.org/jira/browse/RANGER-3797
Repository: ranger
Description
-------
If solr service config contains no longer supported access types e.g - others, solr_admin then service/zone service creation will fail.
Added changes in java patch to handle upgrade case (Before upgrade If serivce config had others or solr_admin access types then removing and updating the service config during upgrade.)
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 949967cd3
Diff: https://reviews.apache.org/r/74031/diff/3/
Changes: https://reviews.apache.org/r/74031/diff/2-3/
Testing
-------
Verified upgrade and checked able to create security zone.
Thanks,
Mateen Mansoori
Re: Review Request 74031: RANGER-3797 : Not able to create security zone for solr service after upgrade
Posted by Mateen Mansoori <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/74031/
-----------------------------------------------------------
(Updated June 21, 2022, 10:07 a.m.)
Review request for ranger, bhavik patel, Dhaval Shah, Dineshkumar Yadav, Abhay Kulkarni, Mehul Parikh, Pradeep Agrawal, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3797
https://issues.apache.org/jira/browse/RANGER-3797
Repository: ranger
Description
-------
If solr service config contains no longer supported access types e.g - others, solr_admin then service/zone service creation will fail.
Added changes in java patch to handle upgrade case (Before upgrade If serivce config had others or solr_admin access types then removing and updating the service config during upgrade.)
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/patch/PatchForSolrSvcDefAndPoliciesUpdate_J10055.java 949967cd3
Diff: https://reviews.apache.org/r/74031/diff/2/
Changes: https://reviews.apache.org/r/74031/diff/1-2/
Testing
-------
Verified upgrade and checked able to create security zone.
Thanks,
Mateen Mansoori