You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/04/12 08:55:31 UTC
[GitHub] [dolphinscheduler] bigdatazhao opened a new pull request, #9458: Added retry when connecting to mysql for task information
bigdatazhao opened a new pull request, #9458:
URL: https://github.com/apache/dolphinscheduler/pull/9458
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
<!--(For example: This pull request adds checkstyle plugin).-->
##
Added retries to get task information in mysql
<!--*(for example:)*
- *Add maven-checkstyle-plugin to root pom.xml*
-->
## Verify this pull request
<!--*(Please pick either of the following options)*-->
Manually verified the change by testing locally
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] zhongjiajie commented on pull request #9458: Added retry when connecting to mysql for task information
Posted by GitBox <gi...@apache.org>.
zhongjiajie commented on PR #9458:
URL: https://github.com/apache/dolphinscheduler/pull/9458#issuecomment-1104745054
I do not think we should add retry in this function, each function query database could have the same issue, maybe we should add in meta database connection.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] SbloodyS commented on pull request #9458: Added retry when connecting to mysql for task information
Posted by GitBox <gi...@apache.org>.
SbloodyS commented on PR #9458:
URL: https://github.com/apache/dolphinscheduler/pull/9458#issuecomment-1096511736
Hi @bigdatazhao ,can you open an issue link to this pr to describe why did you want to do that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng commented on pull request #9458: Added retry when connecting to mysql for task information
Posted by GitBox <gi...@apache.org>.
caishunfeng commented on PR #9458:
URL: https://github.com/apache/dolphinscheduler/pull/9458#issuecomment-1104985789
Hi @bigdatazhao There is the same logic implement by `FailoverExecuteThread`, so it's no need to add retry logic into failoverMaster.
BTW, the latest dev code use the `FailoverService` to unified failover logic, see #9281
I will close this pr, but thanks for your submitting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] caishunfeng closed pull request #9458: Added retry when connecting to mysql for task information
Posted by GitBox <gi...@apache.org>.
caishunfeng closed pull request #9458: Added retry when connecting to mysql for task information
URL: https://github.com/apache/dolphinscheduler/pull/9458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org