You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "reatang (via GitHub)" <gi...@apache.org> on 2024/01/17 09:00:33 UTC
[PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
reatang opened a new pull request, #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156
Header should manage its own changes and builds
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156#issuecomment-1899872135
please make the ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 merged PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "reatang (via GitHub)" <gi...@apache.org>.
reatang commented on PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156#issuecomment-1898457436
> So what you have done is encapsulating releated methods in the `header` object?
Yes, make the Header function cohesive.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156#issuecomment-1897653685
So what you have done is encapsulating releated methods in the `header` object?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "monkeyDluffy6017 (via GitHub)" <gi...@apache.org>.
monkeyDluffy6017 commented on PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156#issuecomment-1897653808
please make the ci pass
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] refactor: inHTTP.Header [apisix-go-plugin-runner]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #156:
URL: https://github.com/apache/apisix-go-plugin-runner/pull/156#issuecomment-1899864450
## [Codecov](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: `1 lines` in your changes are missing coverage. Please review.
> Comparison is base [(`a265bcd`)](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/commit/a265bcd63ca186ff0bf61a3d7ebf46c642266717?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 79.62% compared to head [(`5bbe09d`)](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 79.80%.
> :exclamation: Current head 5bbe09d differs from pull request most recent head c37bbd7. Consider uploading reports for the commit c37bbd7 to get more accurate results
| [Files](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [internal/http/header.go](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-aW50ZXJuYWwvaHR0cC9oZWFkZXIuZ28=) | 97.87% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #156 +/- ##
==========================================
+ Coverage 79.62% 79.80% +0.18%
==========================================
Files 17 17
Lines 1060 1040 -20
==========================================
- Hits 844 830 -14
+ Misses 164 158 -6
Partials 52 52
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/apisix-go-plugin-runner/pull/156?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org