[jira] [Commented] (NIFI-5242) Elasticsearch REST API client has LGPL dependency which must be removed

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16492050#comment-16492050 ] 

ASF GitHub Bot commented on NIFI-5242:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2741

    NIFI-5242: Exclude JTS dependency from Elasticsearch client

    I ran the full suite of unit tests and also tried with DeleteByQueryElasticsearch which uses the  CS that was bringing in the JTS dependency, all worked well.
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [ ] Have you written or updated unit tests to verify your changes?
    - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5242

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2741.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2741
    
----
commit 2edbfa8cd9c4488f79c02c5bbc38b49f54edd7d7
Author: Matthew Burgess <ma...@...>
Date:   2018-05-27T15:19:43Z

    NIFI-5242: Exclude JTS dependency from Elasticsearch client

----


> Elasticsearch REST API client has LGPL dependency which must be removed
> -----------------------------------------------------------------------
>
>                 Key: NIFI-5242
>                 URL: https://issues.apache.org/jira/browse/NIFI-5242
>             Project: Apache NiFi
>          Issue Type: Bug
>            Reporter: Matt Burgess
>            Priority: Major
>
> NIFI-4325 introduced a processor that made use of the Elasticsearch 5.x REST API client (which replaced the older native transport client). However they neglected to make the JTS dependency optional, as it is LGPL-licensed, and thus it is included as a transitive dependency in NiFi, which is a violation of the Apache Software Foundation guidelines.
> As it was apparently intended to be an optional dependency (see [https://github.com/elastic/elasticsearch/issues/28899)], we should be able to exclude it from the NiFi Maven build, but we'll need to run regression tests to make sure nothing gets broken as a result.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)