You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/06/03 03:07:04 UTC
[GitHub] [spark] xinrong-databricks commented on a change in pull request #32738: [SPARK-35474] Enable disallow_untyped_defs mypy check for pyspark.pandas.indexing.
xinrong-databricks commented on a change in pull request #32738:
URL: https://github.com/apache/spark/pull/32738#discussion_r644451445
##########
File path: python/pyspark/pandas/indexing.py
##########
@@ -1246,7 +1255,8 @@ def _select_cols_by_iterable(
% (len(cast(Sized, cols_sel)), len(self._internal.column_labels))
)
if isinstance(cols_sel, pd.Series):
- if not cols_sel.index.sort_values().equals(self._psdf.columns.sort_values()):
+ if not cols_sel.index.sort_values().equals(
+ self._psdf.columns.sort_values()): # type: ignore
Review comment:
Shall we adjust the indent of this line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org