You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@directory.apache.org by fe...@apache.org on 2010/09/24 13:52:07 UTC
svn commit: r1000823 -
/directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Author: felixk
Date: Fri Sep 24 11:52:07 2010
New Revision: 1000823
URL: http://svn.apache.org/viewvc?rev=1000823&view=rev
Log:
Interesting what one can find when eliminating javadoc formatting issues... And astonishing enough it's working. That's what I call a stable and fault-tolerant application :-)
Modified:
directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Modified: directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
URL: http://svn.apache.org/viewvc/directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java?rev=1000823&r1=1000822&r2=1000823&view=diff
==============================================================================
--- directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java (original)
+++ directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java Fri Sep 24 11:52:07 2010
@@ -66,7 +66,7 @@ public interface Transport
/**
* Set the IoAcceptor
* @param acceptor The IoAcceptor to set
- *
+ */
void setAcceptor ( IoAcceptor acceptor );
Re: svn commit: r1000823 - /directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Posted by Emmanuel Lecharny <el...@gmail.com>.
On 9/24/10 2:13 PM, Stefan Seelmann wrote:
> The acceptor is created lazily in TcpTransport and UdpTransport. There
> is no way to set it from outside. So let's remove the setAcceptor()
> method from the Transport interface.
Absolutely.
I don't know why I commented the method back 2 years ago, but that was
basically the wrong move. Get rid of it completely !
--
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com
Re: svn commit: r1000823 - /directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Posted by Stefan Seelmann <se...@apache.org>.
The acceptor is created lazily in TcpTransport and UdpTransport. There
is no way to set it from outside. So let's remove the setAcceptor()
method from the Transport interface.
On Fri, Sep 24, 2010 at 2:04 PM, Stefan Seelmann <se...@apache.org> wrote:
> On Fri, Sep 24, 2010 at 1:52 PM, <fe...@apache.org> wrote:
>> Interesting what one can find when eliminating javadoc formatting issues... And astonishing enough it's working. That's what I call a stable and fault-tolerant application :-)
>
> Indeed.
>
>> --- directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java (original)
>> +++ directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java Fri Sep 24 11:52:07 2010
>> @@ -66,7 +66,7 @@ public interface Transport
>> /**
>> * Set the IoAcceptor
>> * @param acceptor The IoAcceptor to set
>> - *
>> + */
>> void setAcceptor ( IoAcceptor acceptor );
>
> Hm, maybe that was intended, because now the build fails as the
> classes TcpTransport and UdpTransport don't implement the
> setAcceptor() method. I think we should remove the setAcceptor from
> the interface? Anyone?
>
> Kind Regards,
> Stefan
>
Re: svn commit: r1000823 - /directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Posted by Felix Knecht <fe...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
>> --- directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java (original)
>> +++ directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java Fri Sep 24 11:52:07 2010
>> @@ -66,7 +66,7 @@ public interface Transport
>> /**
>> * Set the IoAcceptor
>> * @param acceptor The IoAcceptor to set
>> - *
>> + */
>> void setAcceptor ( IoAcceptor acceptor );
>
> Hm, maybe that was intended, because now the build fails as the
> classes TcpTransport and UdpTransport don't implement the
> setAcceptor() method.
Ouch! I'll revert it to make the build work again ...
Sorry
Felix
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.16 (GNU/Linux)
Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org/
iEYEARECAAYFAkyclcEACgkQ2lZVCB08qHGApwCfRQM9NoA36j/JR2IHc2OgAcBQ
QegAoOec7wmAhM+qx7aA5HnypWpLoLXm
=51M4
-----END PGP SIGNATURE-----
Re: svn commit: r1000823 - /directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java
Posted by Stefan Seelmann <se...@apache.org>.
On Fri, Sep 24, 2010 at 1:52 PM, <fe...@apache.org> wrote:
> Interesting what one can find when eliminating javadoc formatting issues... And astonishing enough it's working. That's what I call a stable and fault-tolerant application :-)
Indeed.
> --- directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java (original)
> +++ directory/apacheds/trunk/protocol-shared/src/main/java/org/apache/directory/server/protocol/shared/transport/Transport.java Fri Sep 24 11:52:07 2010
> @@ -66,7 +66,7 @@ public interface Transport
> /**
> * Set the IoAcceptor
> * @param acceptor The IoAcceptor to set
> - *
> + */
> void setAcceptor ( IoAcceptor acceptor );
Hm, maybe that was intended, because now the build fails as the
classes TcpTransport and UdpTransport don't implement the
setAcceptor() method. I think we should remove the setAcceptor from
the interface? Anyone?
Kind Regards,
Stefan