You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@kyuubi.apache.org by "zml1206 (via GitHub)" <gi...@apache.org> on 2023/10/30 17:04:25 UTC
[PR] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
zml1206 opened a new pull request, #5567:
URL: https://github.com/apache/kyuubi/pull/5567
<!--
Thanks for sending a pull request!
Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/CONTRIBUTING.html
2. If the PR is related to an issue in https://github.com/apache/kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->
### _Why are the changes needed?_
To close #5565.
- Support Delete from table command for Delta Lake in Authz.
- Support Insert table command for Delta Lake in Authz.
- Support Update table command for Delta Lake in Authz.
- Remove useless `CreateDeltaTableCommand`.
- Reduce the fields of `createTableSql`.
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.readthedocs.io/en/master/contributing/code/testing.html#running-tests) locally before make a pull request
### _Was this patch authored or co-authored using generative AI tooling?_
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 closed pull request #5567: [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake
URL: https://github.com/apache/kyuubi/pull/5567
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1786320744
@zml1206 creating a logic revert PR SGTM, please go ahead
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1785687698
Why CreateDeltaTableCommand is useless?
Nit: for PR description and code comments, explain **WHY** is more important than **WHAT**, since the code usually is clear enough for reviewer to understand what you are doing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1785711721
> Why CreateDeltaTableCommand is useless?
>
> Nit: for PR description and code comments, explain **WHY** is more important than **WHAT**, since the code usually is clear enough for reviewer to understand what you are doing.
Before, I misunderstood the role of `table_command_spec.json` in #5529 ,The logical plans for Delta Lake create table and replace table are `org.apache.spark.sql.catalyst.plans.logical.CreateTable` and `org.apache.spark.sql.catalyst.plans.logical.CreateV2Table` and `org. apache.spark.sql.catalyst.plans.logical.ReplaceTable`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1788445340
New PR #5596
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "zml1206 (via GitHub)" <gi...@apache.org>.
zml1206 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1786319421
Reverting #5529 has conflict, how about create a followup PR for #5529 first to remove useless `org.apache.spark.sql.delta.commands.CreateDeltaTableCommand` first, and then resubmit #5565? @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org
Re: [PR] [KYUUBI #5565][AUTHZ] Support Delete/Insert/Update table command for Delta Lake [kyuubi]
Posted by "pan3793 (via GitHub)" <gi...@apache.org>.
pan3793 commented on PR #5567:
URL: https://github.com/apache/kyuubi/pull/5567#issuecomment-1785742184
@zml1206 for such case, reverting https://github.com/apache/kyuubi/issues/5529 independent is preferred, to gain more clear commit history
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org