[GitHub] [fluo-muchos] keith-turner commented on a change in pull request #288: Refactor config

[GitBox <gi...@apache.org>]

keith-turner commented on a change in pull request #288: Refactor config
URL: https://github.com/apache/fluo-muchos/pull/288#discussion_r332164866
 
 

 ##########
 File path: lib/muchos/config/base.py
 ##########
 @@ -216,21 +260,9 @@ def checksum_ver(self, software, version):
             exit('ERROR - Failed to find checksums for %s %s in %s' % (software, version, self.checksums_path))
         return self.checksums_d[key]
 
-    def verify_instance_type(self, instance_type):
-        if not self.cluster_template_d:
-            if get_arch(instance_type) == 'pvm':
-                exit("ERROR - Configuration contains instance type '{0}' that uses pvm architecture."
-                     "Only hvm architecture is supported!".format(instance_type))
-
+    @abstractmethod
     def instance_tags(self):
 
 Review comment:
   Would it be possible to push this down to EC2 config and not define it here?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services