[GitHub] [incubator-doris] imay commented on a change in pull request #1597: Support checking error data row when doing INSERT

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #1597: Support checking error data row when doing INSERT
URL: https://github.com/apache/incubator-doris/pull/1597#discussion_r312727579
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/qe/StmtExecutor.java
 ##########
 @@ -690,7 +692,16 @@ private void handleInsertStmt() throws Exception {
 
             // set to OK, which means the insert load job is successfully submitted.
             // and user can check the job's status by label.
-            context.getState().setOk("{'label':'" + uuid.toString() + "'}");
+            Map<String, String> res = Maps.newHashMap();
 
 Review comment:
   This can make some old client code not compatible. I think if client can get tracking URL from show load, we can not return URL here. 
   
   And this version is deprecated, I think it's better to keep old version's return

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org