[GitHub] [iceberg] ajantha-bhat commented on a diff in pull request #6787: Spark: Update register table procedure test case for all the catalogs

["ajantha-bhat (via GitHub)" <gi...@apache.org>]

ajantha-bhat commented on code in PR #6787:
URL: https://github.com/apache/iceberg/pull/6787#discussion_r1101483409


##########
spark/v3.2/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestRegisterTableProcedure.java:
##########
@@ -55,10 +53,6 @@ public void dropTables() {
 
   @Test
   public void testRegisterTable() throws NoSuchTableException, ParseException {

Review Comment:
   Yes. 
   Already API level test is there for each catalog for register table.
   Configuring other catalogs in this test case is hard (like Glue, REST). It is better to keep them as integration tests (may in in a follow up PR)
   
   Now removing this check will make sure that this testcase runs for hadoop, hive, spark catalog.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org