[GitHub] [shardingsphere] ReyYang commented on a change in pull request #15571: For #12449: If a scaling job failed or stopped then it could not be started by DistSQL except restarting proxy

[GitBox <gi...@apache.org>]

ReyYang commented on a change in pull request #15571:
URL: https://github.com/apache/shardingsphere/pull/15571#discussion_r812539820



##########
File path: shardingsphere-kernel/shardingsphere-data-pipeline/shardingsphere-data-pipeline-core/src/main/java/org/apache/shardingsphere/data/pipeline/scenario/rulealtered/RuleAlteredJob.java
##########
@@ -53,7 +53,7 @@ public void execute(final ShardingContext shardingContext) {
         } catch (final RuntimeException ex) {
             // CHECKSTYLE:ON
             log.error("job prepare failed, {}-{}", shardingContext.getJobName(), shardingContext.getShardingItem());
-            jobContext.close();
+            RuleAlteredJobWorker.getPIPELINE_JOB_EXECUTOR().stopJob(shardingContext.getJobName());

Review comment:
       RuleAlteredJobSchedulerCenter.stop method will close jobContext.close()




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org