You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2020/08/31 17:57:28 UTC

[GitHub] [calcite] michaelmior commented on a change in pull request #2123: Support for Elasticsearch basic authentication

michaelmior commented on a change in pull request #2123:
URL: https://github.com/apache/calcite/pull/2123#discussion_r480293259



##########
File path: elasticsearch/src/main/java/org/apache/calcite/adapter/elasticsearch/ElasticsearchSchemaFactory.java
##########
@@ -88,7 +92,9 @@ public ElasticsearchSchemaFactory() {
       }
       final String pathPrefix = (String) map.get("pathPrefix");
       // create client
-      final RestClient client = connect(hosts, pathPrefix);
+      String jdbcUser = (String) map.get("jdbcUser");
+      String jdbcPassword = (String) map.get("jdbcPassword");
+      final RestClient client = connect(hosts, pathPrefix, jdbcUser, jdbcPassword);

Review comment:
       Given that this refers to the username and password for Elasticsearch and is not directly related to JDBC, this should be changed to `username` and `password`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org