You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@shindig.apache.org by Jiaqing Guo <gu...@cn.ibm.com> on 2014/10/18 17:16:58 UTC

Re: Review Request 22363: The gadget loaded by Shindig doesn't contain proper title element

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/22363/
-----------------------------------------------------------

(Updated Oct. 18, 2014, 3:16 p.m.)


Review request for shindig, Dan Dumont, Ryan Baxter, Rich Thompson, and Stanton Sievers.


Changes
-------

Fix the problem in the test case and add test case for my changest.


Bugs: SHINDIG-1978
    https://issues.apache.org/jira/browse/SHINDIG-1978


Repository: shindig


Description (updated)
-------

If gadget spec contains a "ModulePrefs" tag with "title" attribute like below:
<ModulePrefs title="this is title" description="Hello World Embedded Experience gadget" height="400" width="500">
Then expect the loaded gadget should contain proper "title" element like below:
<html>
<head>
<title>this is title</title>
......
But the actual result is the load gadget doesn't contain "title" element.


Diffs (updated)
-----

  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/main/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriter.java 1605175 
  http://svn.apache.org/repos/asf/shindig/trunk/java/gadgets/src/test/java/org/apache/shindig/gadgets/render/RenderingGadgetRewriterTest.java 1533559 
  http://svn.apache.org/repos/asf/shindig/trunk/java/server/src/test/java/org/apache/shindig/server/endtoend/EndToEndTest.java 1620491 

Diff: https://reviews.apache.org/r/22363/diff/


Testing
-------


Thanks,

Jiaqing Guo