[GitHub] [spark] cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files

[GitBox <gi...@apache.org>]

cloud-fan commented on a change in pull request #24892: [SPARK-25341][Core] Support rolling back a shuffle map stage and re-generate the shuffle files
URL: https://github.com/apache/spark/pull/24892#discussion_r311048475
 
 

 ##########
 File path: common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/BlockStoreClient.java
 ##########
 @@ -49,12 +50,24 @@ public abstract void fetchBlocks(
       String host,
       int port,
       String execId,
+      int shuffleGenerationId,
 
 Review comment:
   does it mean this method can only fetch shuffle blocks? Shall we rename the method?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org