You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Clemens Valiente (Code Review)" <ge...@cloudera.org> on 2019/05/03 08:58:46 UTC
[kudu-CR] throw error on write errors
Clemens Valiente has uploaded this change for review. ( http://gerrit.cloudera.org:8080/13228
Change subject: throw error on write errors
......................................................................
throw error on write errors
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 49 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/1
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 1
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
[kudu-CR] Throw exception on write errors with the kudu-mapreduce client
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#2).
Change subject: Throw exception on write errors with the kudu-mapreduce client
......................................................................
Throw exception on write errors with the kudu-mapreduce client
The kudu-mapreduce package only logs write errors but doesn't act on them.
This can cause jobs appear to be successful despite not writing a single successful row.
Since records are written asynchronously, we need to check for errors during the write process,
and once again when we close the kudu session.
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/2
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 2
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Throw exception on write error with kudu-mapreduce
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: Throw exception on write error with kudu-mapreduce
......................................................................
Patch Set 7:
Looks like there are two Java test failures to fix here:
1) testWriteException(org.apache.kudu.mapreduce.ITKuduTableOutputFormat)
java.io.IOException: Encountered an error while closing this task
at org.apache.kudu.mapreduce.KuduTableOutputFormat$TableRecordWriter.close(KuduTableOutputFormat.java:210)
at org.apache.kudu.mapreduce.ITKuduTableOutputFormat.testWriteException(ITKuduTableOutputFormat.java:115)
...
Caused by: java.io.IOException: java.lang.IllegalStateException: Cannot proceed, the client has already been closed
at org.apache.kudu.mapreduce.KuduTableOutputFormat.shutdownClient(KuduTableOutputFormat.java:144)
at org.apache.kudu.mapreduce.KuduTableOutputFormat.access$000(KuduTableOutputFormat.java:66)
at org.apache.kudu.mapreduce.KuduTableOutputFormat$TableRecordWriter.close(KuduTableOutputFormat.java:208)
... 35 more
Caused by: java.lang.IllegalStateException: Cannot proceed, the client has already been closed
at org.apache.kudu.client.AsyncKuduClient.checkIsClosed(AsyncKuduClient.java:2406)
at org.apache.kudu.client.AsyncKuduClient.shutdown(AsyncKuduClient.java:2350)
at org.apache.kudu.client.KuduClient.shutdown(KuduClient.java:315)
at org.apache.kudu.mapreduce.KuduTableOutputFormat.shutdownClient(KuduTableOutputFormat.java:142)
... 37 more
2) test(org.apache.kudu.mapreduce.ITKuduTableOutputFormat)
java.lang.AssertionError
at org.apache.kudu.mapreduce.KuduTableOutputFormat.setConf(KuduTableOutputFormat.java:135)
at org.apache.kudu.mapreduce.ITKuduTableOutputFormat.test(ITKuduTableOutputFormat.java:63)
...
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 7
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 May 2019 16:11:38 +0000
Gerrit-HasComments: No
[kudu-CR] HIVE-12971 Add a Hive serde for Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: HIVE-12971 Add a Hive serde for Kudu
......................................................................
Patch Set 8:
(8 comments)
http://gerrit.cloudera.org:8080/#/c/13228/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/13228/7//COMMIT_MSG@7
PS7, Line 7: HIVE-12971 Add a Hive serde for Kudu
Nit: please reformat as:
[kudu-mapreduce] throw exception on write error
That way it's a little easier to filter on the particular Kudu module.
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
File java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java:
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java@208
PS7, Line 208: // This is the only place where we have access to the context in the record writer,
Seems like this should be part of the finally block.
Also, if close() can be called after exception in setConf(), shutdownClient() ought to check whether client is null before calling shutdown().
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java@209
PS7, Line 209: // so set the counter here.
: taskAttemptContext.getCounter(Counters.ROWS_WITH_ERRORS).setValue(rowsWithErrors.get());
:
Not really sure I see the point of this. Both processRowErrors() and shutdownClient() purport to throw IOException. Are there really a bunch of unchecked exceptions they can throw, which we'd want to wrap in IOException? Certainly wrapping an IOException in this IOException isn't particularly necessary.
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java@225
PS7, Line 225:
There should be a space here (between 'encountered' and the double quote).
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java@225
PS7, Line 225: }
This line is too long, can you wrap it?
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
File java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java:
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java@50
PS7, Line 50: KuduTableOutputFormat output = new KuduTableOutputFormat();
: Configuration conf = new Configuration();
: conf.set(KuduTableOutputFormat.MASTER_ADDRESSES_KEY, harness.getMasterAddressesAsString());
:
Why is this necessary? KuduTestHarness already has an @After that shuts down its client.
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java@113
PS7, Line 113:
Check out https://github.com/junit-team/junit4/wiki/Exception-testing; there's an easier way to test that an exception is thrown:
@Test(expected = IOException.class)
http://gerrit.cloudera.org:8080/#/c/13228/7/java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java@117
PS7, Line 117:
Line too long, please wrap.
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 8
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 May 2019 16:21:07 +0000
Gerrit-HasComments: Yes
[kudu-CR] Throw exception on write error with kudu-mapreduce
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#6).
Change subject: Throw exception on write error with kudu-mapreduce
......................................................................
Throw exception on write error with kudu-mapreduce
The kudu-mapreduce package only logs write errors but doesn't act on them.
This can cause jobs appear to be successful despite not writing
a single successful row.
Since records are written asynchronously, we need to check for errors
during the write process, and once again when we close the kudu session.
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 53 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/6
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 6
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Throw exception on write error with kudu-mapreduce
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Clemens Valiente has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: Throw exception on write error with kudu-mapreduce
......................................................................
Patch Set 7:
Yes, I had a look at it and it turns out kudu-mapreduce doesn't support running two unit tests on the KuduOutputFormat...
it would need quite some work refactoring it and I am not sure mapreduce is still used enough to be worth it. I decided to not use this package for the hive serde.
> Looks like there are two Java test failures to fix here:
>
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 7
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 May 2019 16:14:54 +0000
Gerrit-HasComments: No
[kudu-CR] Throw exception on write error with kudu-mapreduce
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#4).
Change subject: Throw exception on write error with kudu-mapreduce
......................................................................
Throw exception on write error with kudu-mapreduce
The kudu-mapreduce package only logs write errors but doesn't act on them.
This can cause jobs appear to be successful despite not writing
a single successful row.
Since records are written asynchronously, we need to check for errors
during the write process, and once again when we close the kudu session.
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/4
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 4
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] HIVE-12971 Add a Hive serde for Kudu
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Adar Dembo,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#8).
Change subject: HIVE-12971 Add a Hive serde for Kudu
......................................................................
HIVE-12971 Add a Hive serde for Kudu
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-hive-serde/src/main/java/org/apache/kudu/hive/serde/HiveKuduBridgeUtils.java
M java/kudu-hive-serde/src/main/java/org/apache/kudu/hive/serde/HiveKuduConstants.java
M java/kudu-hive-serde/src/main/java/org/apache/kudu/hive/serde/KuduStorageHandler.java
M java/kudu-hive-serde/src/main/java/org/apache/kudu/hive/serde/input/KuduTableInputFormat.java
M java/kudu-hive-serde/src/main/java/org/apache/kudu/hive/serde/output/KuduRecordUpserter.java
5 files changed, 61 insertions(+), 87 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/8
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 8
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] HIVE-12971 Add a Hive serde for Kudu
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Clemens Valiente has abandoned this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: HIVE-12971 Add a Hive serde for Kudu
......................................................................
Abandoned
not fixing kudu-mapreduce further
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 8
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] Throw exception on write errors with kudu-mapreduce
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#3).
Change subject: Throw exception on write errors with kudu-mapreduce
......................................................................
Throw exception on write errors with kudu-mapreduce
The kudu-mapreduce package only logs write errors but doesn't act on them.
This can cause jobs appear to be successful despite not writing
a single successful row.
Since records are written asynchronously, we need to check for errors
during the write process, and once again when we close the kudu session.
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/3
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 3
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
[kudu-CR] HIVE-12971 Add a Hive serde for Kudu
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: HIVE-12971 Add a Hive serde for Kudu
......................................................................
Patch Set 8:
> Patch Set 8:
>
> The issue being that there's too much static state in KuduTableOutputFormat that can't be reset between tests? Is it MULTITON? Seems easy enough to add a test-only method that resets it in an @After.
>
That seems like it would also cause problems when MR's JVM reuse feature is enabled
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 8
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>
Gerrit-Comment-Date: Fri, 03 May 2019 16:40:45 +0000
Gerrit-HasComments: No
[kudu-CR] HIVE-12971 Add a Hive serde for Kudu
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/13228 )
Change subject: HIVE-12971 Add a Hive serde for Kudu
......................................................................
Patch Set 8:
> Yes, I had a look at it and it turns out kudu-mapreduce doesn't support running two unit tests on the KuduOutputFormat...
> it would need quite some work refactoring it and I am not sure mapreduce is still used enough to be worth it. I decided to not use this package for the hive serde.
The issue being that there's too much static state in KuduTableOutputFormat that can't be reset between tests? Is it MULTITON? Seems easy enough to add a test-only method that resets it in an @After.
Anyway kudu-mapreduce is still an active project as far as we're concerned, so this contribution would be most welcome.
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 8
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Fri, 03 May 2019 16:25:40 +0000
Gerrit-HasComments: No
[kudu-CR] Throw exception on write error with kudu-mapreduce
Posted by "Clemens Valiente (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/13228
to look at the new patch set (#5).
Change subject: Throw exception on write error with kudu-mapreduce
......................................................................
Throw exception on write error with kudu-mapreduce
The kudu-mapreduce package only logs write errors but doesn't act on them.
This can cause jobs appear to be successful despite not writing
a single successful row.
Since records are written asynchronously, we need to check for errors
during the write process, and once again when we close the kudu session.
Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
---
M java/kudu-mapreduce/src/main/java/org/apache/kudu/mapreduce/KuduTableOutputFormat.java
M java/kudu-mapreduce/src/test/java/org/apache/kudu/mapreduce/ITKuduTableOutputFormat.java
2 files changed, 47 insertions(+), 3 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/28/13228/5
--
To view, visit http://gerrit.cloudera.org:8080/13228
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I6db6a59104425c396fbbeb2105bf2c777cc348c7
Gerrit-Change-Number: 13228
Gerrit-PatchSet: 5
Gerrit-Owner: Clemens Valiente <cl...@gmail.com>
Gerrit-Reviewer: Kudu Jenkins (120)