[GitHub] [hbase] saintstack commented on a change in pull request #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present

[GitBox <gi...@apache.org>]

saintstack commented on a change in pull request #1293: HBASE-23970 TestUsersOperationsWithSecureHadoop fails when an existing ticket is present
URL: https://github.com/apache/hbase/pull/1293#discussion_r394780239
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/security/TestUsersOperationsWithSecureHadoop.java
 ##########
 @@ -65,11 +67,19 @@
   private static String CLIENT_NAME;
 
   @BeforeClass
-  public static void destroyAndSetup() throws Exception {
-    //destroy localhost kerberos users
-    Process process = Runtime.getRuntime().exec(new String[]{"bash", "-c", "kdestroy"});
-    process.waitFor(2, TimeUnit.SECONDS);
 
 Review comment:
   So, the previous exec w/ its kdestroy is better than klist with a 'notice' IMO. What tends to happen is you run test suite and then one hour in, it will fail with complaint about unmatched user for old ticket. WIth kdestroy, that doesn't happen. Means old ticket gets killed which should be fine most of the time -- you just re-kinit  (unless you running test suite on some critical system).
   
   Nick's idea of narrowing test so it only concerned about test ticket would be best. Not sure how to do that though myself.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services