You are viewing a plain text version of this content. The canonical link for it is here.
Posted to server-dev@james.apache.org by ro...@apache.org on 2020/06/08 13:16:09 UTC
[james-project] 15/30: JAMES-3179 Suppress harmless ErrorProne
errors
This is an automated email from the ASF dual-hosted git repository.
rouazana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/james-project.git
commit 5f19a090171b8b666a084984beaf6651ef992202
Author: Gautier DI FOLCO <gd...@linagora.com>
AuthorDate: Tue May 12 15:42:54 2020 +0200
JAMES-3179 Suppress harmless ErrorProne errors
---
.../james/mailbox/elasticsearch/query/CriterionConverter.java | 1 +
.../org/apache/james/mailbox/quota/model/QuotaThresholdTest.java | 1 +
.../apache/james/mailbox/store/MailboxMessageResultImplTest.java | 1 +
mailet/api/src/main/java/org/apache/mailet/Serializer.java | 1 +
.../src/test/java/org/apache/james/mpt/api/ImapFeaturesTest.java | 6 ++++--
.../src/test/java/org/apache/james/util/FunctionalUtilsTest.java | 2 ++
.../src/test/java/org/apache/james/rrt/lib/MappingsImplTest.java | 9 ++++++---
7 files changed, 16 insertions(+), 5 deletions(-)
diff --git a/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java b/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
index 0d6c24a..0f99287 100644
--- a/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
+++ b/mailbox/elasticsearch/src/main/java/org/apache/james/mailbox/elasticsearch/query/CriterionConverter.java
@@ -215,6 +215,7 @@ public class CriterionConverter {
}
}
+ @SuppressWarnings("ReturnValueIgnored")
private BoolQueryBuilder convertToBoolQuery(Stream<QueryBuilder> stream, BiFunction<BoolQueryBuilder, QueryBuilder, BoolQueryBuilder> addCriterionToBoolQuery) {
return stream.collect(Collector.of(QueryBuilders::boolQuery,
addCriterionToBoolQuery::apply,
diff --git a/mailbox/plugin/quota-mailing/src/test/java/org/apache/james/mailbox/quota/model/QuotaThresholdTest.java b/mailbox/plugin/quota-mailing/src/test/java/org/apache/james/mailbox/quota/model/QuotaThresholdTest.java
index 15a47e8..f53658e 100644
--- a/mailbox/plugin/quota-mailing/src/test/java/org/apache/james/mailbox/quota/model/QuotaThresholdTest.java
+++ b/mailbox/plugin/quota-mailing/src/test/java/org/apache/james/mailbox/quota/model/QuotaThresholdTest.java
@@ -133,6 +133,7 @@ public class QuotaThresholdTest {
}
@Test
+ @SuppressWarnings("SelfComparison")
public void compareToShouldReturnZeroWhenEquals() {
assertThat(_75.compareTo(_75))
.isEqualTo(0);
diff --git a/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxMessageResultImplTest.java b/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxMessageResultImplTest.java
index af19971..cef27ba 100644
--- a/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxMessageResultImplTest.java
+++ b/mailbox/store/src/test/java/org/apache/james/mailbox/store/MailboxMessageResultImplTest.java
@@ -72,6 +72,7 @@ class MailboxMessageResultImplTest {
@Test
+ @SuppressWarnings("SelfComparison")
void testCompareToReflexive() {
assertThat(msgResultA.compareTo(msgResultA)).isEqualTo(0);
}
diff --git a/mailet/api/src/main/java/org/apache/mailet/Serializer.java b/mailet/api/src/main/java/org/apache/mailet/Serializer.java
index 17855e4..cc3f787 100644
--- a/mailet/api/src/main/java/org/apache/mailet/Serializer.java
+++ b/mailet/api/src/main/java/org/apache/mailet/Serializer.java
@@ -59,6 +59,7 @@ import com.google.common.collect.ImmutableMap;
*
* @since Mailet API v3.2
*/
+@SuppressWarnings("EqualsHashCode")
public interface Serializer<T> {
JsonNode serialize(T object);
diff --git a/mpt/core/src/test/java/org/apache/james/mpt/api/ImapFeaturesTest.java b/mpt/core/src/test/java/org/apache/james/mpt/api/ImapFeaturesTest.java
index d6790ba..8411f84 100644
--- a/mpt/core/src/test/java/org/apache/james/mpt/api/ImapFeaturesTest.java
+++ b/mpt/core/src/test/java/org/apache/james/mpt/api/ImapFeaturesTest.java
@@ -62,13 +62,15 @@ public class ImapFeaturesTest {
}
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("CheckReturnValue")
public void supportsShouldThrowOnNullFeature() {
- assertThat(ImapFeatures.of().supports((Feature)null));
+ ImapFeatures.of().supports((Feature)null);
}
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("CheckReturnValue")
public void supportsShouldThrowOnNullFeatureArray() {
- assertThat(ImapFeatures.of().supports((Feature[])null));
+ ImapFeatures.of().supports((Feature[])null);
}
diff --git a/server/container/util/src/test/java/org/apache/james/util/FunctionalUtilsTest.java b/server/container/util/src/test/java/org/apache/james/util/FunctionalUtilsTest.java
index c62653f..9b603be 100644
--- a/server/container/util/src/test/java/org/apache/james/util/FunctionalUtilsTest.java
+++ b/server/container/util/src/test/java/org/apache/james/util/FunctionalUtilsTest.java
@@ -40,6 +40,7 @@ class FunctionalUtilsTest {
}
@Test
+ @SuppressWarnings("ReturnValueIgnored")
void toFunctionShouldCallConsumer() {
Counter counter = new Counter(26);
Consumer<Integer> consumer = counter::increment;
@@ -58,6 +59,7 @@ class FunctionalUtilsTest {
}
@Test
+ @SuppressWarnings("ReturnValueIgnored")
void identityWithSideEffectShouldCallRunnable() {
Counter counter = new Counter(26);
Runnable runnable = () -> counter.increment(1);
diff --git a/server/data/data-library/src/test/java/org/apache/james/rrt/lib/MappingsImplTest.java b/server/data/data-library/src/test/java/org/apache/james/rrt/lib/MappingsImplTest.java
index 82bbe19..41d428c 100644
--- a/server/data/data-library/src/test/java/org/apache/james/rrt/lib/MappingsImplTest.java
+++ b/server/data/data-library/src/test/java/org/apache/james/rrt/lib/MappingsImplTest.java
@@ -158,9 +158,10 @@ public class MappingsImplTest {
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("CheckReturnValue")
public void containsShouldThrowWhenNull() {
MappingsImpl mappings = MappingsImpl.builder().add(Mapping.regex("toto")).build();
- assertThat(mappings.contains((Mapping.Type)null));
+ mappings.contains((Mapping.Type)null);
}
@Test
@@ -190,9 +191,10 @@ public class MappingsImplTest {
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("CheckReturnValue")
public void selectShouldThrowWhenNull() {
MappingsImpl mappings = MappingsImpl.builder().add(Mapping.regex("toto")).build();
- assertThat(mappings.select((Mapping.Type)null));
+ mappings.select((Mapping.Type)null);
}
@Test
@@ -221,9 +223,10 @@ public class MappingsImplTest {
@Test(expected = NullPointerException.class)
+ @SuppressWarnings("CheckReturnValue")
public void excludeShouldThrowWhenNull() {
MappingsImpl mappings = MappingsImpl.builder().add(Mapping.regex("toto")).build();
- assertThat(mappings.exclude((Mapping.Type)null));
+ mappings.exclude((Mapping.Type)null);
}
@Test
---------------------------------------------------------------------
To unsubscribe, e-mail: server-dev-unsubscribe@james.apache.org
For additional commands, e-mail: server-dev-help@james.apache.org