You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2021/04/06 13:03:27 UTC
[GitHub] [couchdb] bessbd opened a new pull request #3493: Increase timeout for continuous filtered changes with doc ids
bessbd opened a new pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493
<!-- Thank you for your contribution!
Please file this form by replacing the Markdown comments
with your text. If a section needs no action - remove it.
Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
of code collaboration. Positive feedback is represented +1 from committers
and negative is a -1. The -1 also means veto, and needs to be addressed
to proceed. Once there are no objections, the PR can be merged by a
CouchDB committer.
See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
## Overview
<!-- Please give a short brief for the pull request,
what problem it solves or how it makes things better. -->
## Testing recommendations
<!-- Describe how we can test your changes.
Does it provides any behaviour that the end users
could notice? -->
## Related Issues or Pull Requests
<!-- If your changes affects multiple components in different
repositories please put links to those issues or pull requests here. -->
## Checklist
- [ ] Code is written and works correctly
- [ ] Changes are covered by tests
- [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
- [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#issuecomment-815592156
Offline I've hinted I'd add a loop to retry the `mix` rebar fetch step, but based on @dch 's input I understand that wouldn't improve the situation at all, so I'll leave it as-is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on a change in pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on a change in pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#discussion_r609042494
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -703,6 +703,7 @@ pipeline {
sh '''
cp js/centos-7/*rpm pkgs/centos7
cp js/centos-8/*rpm pkgs/centos8
+ cd pkgs
cd ../centos7 && createrepo --database .
Review comment:
Done in f9846eb
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3493: Increase timeout for continuous filtered changes with doc ids
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#issuecomment-814905087
Thanks for the help with the publish issue, @mojito317 !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] garrensmith commented on pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
garrensmith commented on pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#issuecomment-815595521
@bessbd can you break this into two commits. One for timeouts and one for jenkins fix
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#issuecomment-815596584
> @bessbd can you break this into two commits. One for timeouts and one for jenkins fix
Thank you for the review, @garrensmith ! Would you be okay with 3? One for the timeouts, one for disabling arm64v8 and one for the Jenkins fix?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd merged pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd merged pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] mojito317 commented on a change in pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
mojito317 commented on a change in pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#discussion_r609039903
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -703,6 +703,7 @@ pipeline {
sh '''
cp js/centos-7/*rpm pkgs/centos7
cp js/centos-8/*rpm pkgs/centos8
+ cd pkgs
cd ../centos7 && createrepo --database .
Review comment:
this is not working since now you are here in the tree:
```
parent
├─pkgs <-- you will be here
├─ centos7
├─ centos8
```
If you change the directory to the parent of `pkgs`, there is no `centos7` or `centos8` in it.
If you do a `cd pkgs/centos7` you can switch from there to `centos8` with `cd ../centos8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] bessbd commented on pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
bessbd commented on pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#issuecomment-815935793
Thank you for the review, @wohali ! I'm about to merge this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] mojito317 commented on a change in pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
mojito317 commented on a change in pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#discussion_r609039903
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -703,6 +703,7 @@ pipeline {
sh '''
cp js/centos-7/*rpm pkgs/centos7
cp js/centos-8/*rpm pkgs/centos8
+ cd pkgs
cd ../centos7 && createrepo --database .
Review comment:
this is not working since now you are here in the tree:
```
parent
├─pkgs <-- you will be here
├─ centos7
├─ centos8
```
If you change the directory to the parent of `pkgs`, there is no `centos7` or `centos8` in it.
If you do a `cd pkgs/centos7` you can switch from there to `centos8` with `../centos8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [couchdb] mojito317 commented on a change in pull request #3493: Fix CI
Posted by GitBox <gi...@apache.org>.
mojito317 commented on a change in pull request #3493:
URL: https://github.com/apache/couchdb/pull/3493#discussion_r609039903
##########
File path: build-aux/Jenkinsfile.full
##########
@@ -703,6 +703,7 @@ pipeline {
sh '''
cp js/centos-7/*rpm pkgs/centos7
cp js/centos-8/*rpm pkgs/centos8
+ cd pkgs
cd ../centos7 && createrepo --database .
Review comment:
this is not workin since now you are here in the tree:
```
parent
├─pkgs <-- you will be here
├─ centos7
├─ centos8
```
If you change the directory to the parent of `pkgs`, there is no `centos7` or `centos8` in it.
If you do a `cd/centos7` you can swich from there to `centos8` with `../centos8`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org