You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/05/13 20:51:41 UTC

[GitHub] [iceberg] aokolnychyi opened a new pull request, #4766: Core: Align snapshot summary property names for delete files

aokolnychyi opened a new pull request, #4766:
URL: https://github.com/apache/iceberg/pull/4766

   This PR renames recently added and unreleased snapshot summary properties for equality and position delete files to match other recent public constants/methods.
   
   Specifically, all other snapshot properties use full words for `equality` and `position`.
   
   ```
   // SnapshotSummary
   public static final String ADDED_POS_DELETES_PROP = "added-position-deletes";
   public static final String REMOVED_POS_DELETES_PROP = "removed-position-deletes";
   public static final String TOTAL_POS_DELETES_PROP = "total-position-deletes";
   public static final String ADDED_EQ_DELETES_PROP = "added-equality-deletes";
   
   // ConvertEqualityDeleteFiles
   int convertedEqualityDeleteFilesCount();
   int addedPositionDeleteFilesCount();
   
   // FileWriterFactory
   EqualityDeleteWriter<T> newEqualityDeleteWriter(...);
   PositionDeleteWriter<T> newPositionDeleteWriter(...);
   
   etc
   ```
   
   Since the new snapshot summary properties haven't been released yet and were added recently, I'd consider renaming them for consistency.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #4766: Core: Align snapshot summary property names for delete files

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on PR #4766:
URL: https://github.com/apache/iceberg/pull/4766#issuecomment-1126611978

   Thanks, @rdblue @szehon-ho @chenjunjiedada!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi commented on pull request #4766: Core: Align snapshot summary property names for delete files

Posted by GitBox <gi...@apache.org>.
aokolnychyi commented on PR #4766:
URL: https://github.com/apache/iceberg/pull/4766#issuecomment-1126493899

   @chenjunjiedada @rdblue, what do you think?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] chenjunjiedada commented on pull request #4766: Core: Align snapshot summary property names for delete files

Posted by GitBox <gi...@apache.org>.
chenjunjiedada commented on PR #4766:
URL: https://github.com/apache/iceberg/pull/4766#issuecomment-1126608372

   +1 to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] rdblue commented on pull request #4766: Core: Align snapshot summary property names for delete files

Posted by GitBox <gi...@apache.org>.
rdblue commented on PR #4766:
URL: https://github.com/apache/iceberg/pull/4766#issuecomment-1126494923

   Looks good to me.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org

[GitHub] [iceberg] aokolnychyi merged pull request #4766: Core: Align snapshot summary property names for delete files

Posted by GitBox <gi...@apache.org>.
aokolnychyi merged PR #4766:
URL: https://github.com/apache/iceberg/pull/4766


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org