You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/08/04 18:47:00 UTC
[jira] [Commented] (BEAM-2729) Post commit fail: Input to
GroupByKey must be of Tuple or Any type
[ https://issues.apache.org/jira/browse/BEAM-2729?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16114804#comment-16114804 ]
ASF GitHub Bot commented on BEAM-2729:
--------------------------------------
GitHub user robertwb opened a pull request:
https://github.com/apache/beam/pull/3690
[BEAM-2729] Allow GBK of union-typed PCollections.
Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam BEAM-2729
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3690.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3690
----
commit 8703aae9eb05fee0ec9238af0cb34dbd3c98e4aa
Author: Robert Bradshaw <ro...@gmail.com>
Date: 2017-08-04T18:43:12Z
[BEAM-2729] Allow GBK of union-typed PCollections.
----
> Post commit fail: Input to GroupByKey must be of Tuple or Any type
> ------------------------------------------------------------------
>
> Key: BEAM-2729
> URL: https://issues.apache.org/jira/browse/BEAM-2729
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Reporter: Ahmet Altay
> Assignee: Robert Bradshaw
>
> root cause: https://github.com/apache/beam/commit/5e71d53ef8c28ec14b6a282b1fe67489c2b3f243
> jenkins: https://builds.apache.org/view/A-D/view/Beam/job/beam_PostCommit_Python_Verify/2864/
> Sample stack:
> ======================================================================
> ERROR: test_iterable_side_input (apache_beam.transforms.sideinputs_test.SideInputsTest)
> ----------------------------------------------------------------------
> Traceback (most recent call last):
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/transforms/sideinputs_test.py", line 177, in test_iterable_side_input
> pipeline.run()
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/testing/test_pipeline.py", line 96, in run
> result = super(TestPipeline, self).run()
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 329, in run
> return self.runner.run(self)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py", line 38, in run
> self.result = super(TestDataflowRunner, self).run(pipeline)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py", line 252, in run
> pipeline.visit(self.group_by_key_input_visitor())
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 354, in visit
> self._root_transform().visit(visitor, self, visited)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 692, in visit
> part.visit(visitor, pipeline, visited)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 692, in visit
> part.visit(visitor, pipeline, visited)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 692, in visit
> part.visit(visitor, pipeline, visited)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/pipeline.py", line 695, in visit
> visitor.visit_transform(self)
> File "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Python_Verify/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py", line 202, in visit_transform
> "Found %s for %s" % (input_type, pcoll))
> ValueError: Input to GroupByKey must be of Tuple or Any type. Found Union[Tuple[NoneType, Tuple[Any, Any]], Tuple[NoneType, Tuple[Any, NoneType]]] for PCollection[assert_that/Group/Flatten.None]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)