You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by fvaleri <gi...@git.apache.org> on 2016/06/25 00:39:26 UTC
[GitHub] zeppelin pull request #1087: Shell intepreter test and doc
GitHub user fvaleri opened a pull request:
https://github.com/apache/zeppelin/pull/1087
Shell intepreter test and doc
### What is this PR for?
Small refactoring to Shell interpreter.
Add missing unit test and initial doc.
### What type of PR is it?
Improvement, Documentation, Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
* Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. [ZEPPELIN-533]
### How should this be tested?
Outline the steps to test the PR here.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/fvaleri/zeppelin shell-intepreter-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1087.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1087
----
commit 247c4e50d1663eaa1fffbc4b304dfe7d4bbbc84e
Author: fvaleri <fe...@gmail.com>
Date: 2016-06-25T00:09:41Z
shell interpreter refactoring
add shell doc and test
commit 6aa2cb69e36f802bb519c53de14735ec03d8a037
Author: fvaleri <fe...@gmail.com>
Date: 2016-06-25T00:18:57Z
\n on doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1087: Shell interpreter test and doc
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1087
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1087
@fvaleri Got it. LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1087
@bzz @jongyoul Now should be ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by bzz <gi...@git.apache.org>.
Github user bzz commented on the issue:
https://github.com/apache/zeppelin/pull/1087
Great clean up and improvement @fvaleri!
While you and @jongyoul are both here - how do you think guys, would it make sense to take care of Shell part of the [ZEPPELIN-804](https://issues.apache.org/jira/browse/ZEPPELIN-804) as prart of this PR as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1087
Another CI job failed even this time on zeppelin-web module.
One is still running but it is very slow (32 min now).
```
[ERROR] Failed to execute goal com.github.eirslett:frontend-maven-plugin:0.0.25:bower (bower install) on project zeppelin-web: Failed to run task: 'bower --allow-root install' failed. (error code 1) -> [Help 1]
```
Anyway, [this one](https://travis-ci.org/apache/zeppelin/builds/141304231) passed and it's the same code, except for a couple on unused imports that I removed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1087
The failure is flaky and irrelevant but we need to ensure all other tests passed. Could you please re-trigger CI?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
Re: [GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by Federico Valeri <fe...@gmail.com>.
Done and tested again. Trevis is OK.
This is only a small refactoring to make it testable.
2016-06-30 1:50 GMT+02:00 jongyoul <gi...@git.apache.org>:
> Github user jongyoul commented on the issue:
>
> https://github.com/apache/zeppelin/pull/1087
>
> Could you please rebase this from current master?
>
>
> ---
> If your project is set up for it, you can reply to this email and have your
> reply appear on GitHub as well. If your project does not have this feature
> enabled and wishes so, or if the feature is enabled but not working, please
> contact infrastructure at infrastructure@apache.org or file a JIRA ticket
> with INFRA.
> ---
>
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by jongyoul <gi...@git.apache.org>.
Github user jongyoul commented on the issue:
https://github.com/apache/zeppelin/pull/1087
Could you please rebase this from current master?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1087: Shell interpreter test and doc
Posted by fvaleri <gi...@git.apache.org>.
Github user fvaleri commented on the issue:
https://github.com/apache/zeppelin/pull/1087
@jongyoul done and CI is ok.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---