You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@zeppelin.apache.org by "miinhho (via GitHub)" <gi...@apache.org> on 2026/10/07 10:48:58 UTC

[PR] [ZEPPELIN-6676] Accept both Angular object removal payload shapes [zeppelin]

miinhho opened a new pull request, #5557:
URL: https://github.com/apache/zeppelin/pull/5557

   ### What is this PR for?
   
   The server emits two ANGULAR_OBJECT_REMOVE payload shapes. Interpreter removal supplies top-level `name`; client unbind supplies `angularObject.name`.
   
   Represent both shapes and export a shared SDK helper using `data.name ?? data.angularObject?.name`. Update the existing Angular consumer to use this normalized identifier while preserving paragraph isolation and avoiding feedback messages.
   
   Server evidence:
   - `zeppelin-server/src/main/java/org/apache/zeppelin/socket/NotebookServer.java:1518-1528,2276-2291`
   
   ### What type of PR is it?
   
   Bug Fix
   
   ### Todos
   
   - [x] Represent and normalize both removal payloads.
   - [x] Test both shapes, name precedence and paragraph isolation.
   
   ### What is the Jira issue?
   
   https://issues.apache.org/jira/browse/ZEPPELIN-6676
   
   Slice 3 of 3: Angular object removal compatibility. Slice 1 merged in #5539 and slice 2 merged in #5544. This PR is based on the merged slice 2 and retains its review changes, including `LegacyInput`.
   
   ### How should this be tested?
   
   Run from the repository root after installing frontend dependencies:
   
   ```sh
   cd zeppelin-web-angular
   npm run typecheck:sdk-contracts
   npm run test:shell
   npm run check:websocket-contract
   ```
   
   ### Screenshots (if appropriate)
   
   Not required.
   
   ### Questions:
   
   - Does the license files need to update? No.
   - Is there breaking changes for older versions? Consumers must normalize the identifier instead of assuming top-level `name` is always present. Both existing server shapes are accepted. No server wire-format change.
   - Does this needs documentation? The SDK helper and regression tests show both payload shapes and normalization.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6676] Accept both Angular object removal payload shapes [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha merged PR #5557:
URL: https://github.com/apache/zeppelin/pull/5557


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] [ZEPPELIN-6676] Accept both Angular object removal payload shapes [zeppelin]

Posted by "voidmatcha (via GitHub)" <gi...@apache.org>.
voidmatcha commented on PR #5557:
URL: https://github.com/apache/zeppelin/pull/5557#issuecomment-6057413284

   Merged into master (883c9d65).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org