You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Jens Geyer (JIRA)" <ji...@apache.org> on 2015/06/11 23:37:00 UTC

[jira] [Commented] (THRIFT-3184) Thrift Go leaves file descriptors open

    [ https://issues.apache.org/jira/browse/THRIFT-3184?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14582546#comment-14582546 ] 

Jens Geyer commented on THRIFT-3184:
------------------------------------

GitHub user prashantv opened a pull request:

    https://github.com/apache/thrift/pull/518

    On non-200 HTTP responses, the body was not being closed.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prashantv/thrift master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/thrift/pull/518.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #518
    
----
commit b5530c48b0de47efd4688f6b9fa64ea2113c5ef9
Author: Prashant Varanasi <pr...@uber.com>
Date:   2015-06-11T16:48:12Z

    On non-200 HTTP responses, the body was not being closed.

----

> Thrift Go leaves file descriptors open
> --------------------------------------
>
>                 Key: THRIFT-3184
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3184
>             Project: Thrift
>          Issue Type: Bug
>          Components: Go - Library
>            Reporter: Ian Lozinski
>            Assignee: Jens Geyer
>
> Whenever a post request returns anything but 200, the file descriptor for the connection is left in the OPEN_WAIT state until the program exits leaving the client unusable even after calling client.Transport.Close(). 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)