You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/13 17:52:26 UTC
[GitHub] [superset] amitmiran137 opened a new pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
amitmiran137 opened a new pull request #13530:
URL: https://github.com/apache/superset/pull/13530
### SUMMARY
follow PR that introduced get charts of a dashboard: https://github.com/apache/superset/pull/12978
introducing an explicit security access test for get_charts endpoint
this is making sure that that use-case will never break in the future
### BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
<!--- Skip this if not applicable -->
### TEST PLAN
<!--- What steps should be taken to verify the changes -->
### ADDITIONAL INFORMATION
<!--- Check any relevant boxes with "x" -->
<!--- HINT: Include "Fixes #nnn" if you are fixing an existing issue -->
- [ ] Has associated issue:
- [ ] Changes UI
- [ ] Requires DB Migration.
- [ ] Confirm DB Migration upgrade and downgrade tested.
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.89%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.27% -5.90%
==========================================
Files 917 821 -96
Lines 46130 41006 -5124
Branches 5600 4227 -1373
==========================================
- Hits 35595 29225 -6370
- Misses 10403 11781 +1378
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.50% <89.36%> (+0.04%)` | :arrow_up: |
| presto | `?` | |
| python | `80.50% <89.36%> (-0.47%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [549 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `0.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 77.84% +0.68%
==========================================
Files 917 920 +3
Lines 46130 48692 +2562
Branches 5600 5517 -83
==========================================
+ Hits 35595 37906 +2311
- Misses 10403 10654 +251
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.58% <ø> (+0.50%)` | :arrow_up: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `81.28% <ø> (+0.82%)` | :arrow_up: |
| presto | `80.12% <ø> (ø)` | |
| python | `81.83% <ø> (+0.87%)` | :arrow_up: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `86.58% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `97.77% <0.00%> (-0.57%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.19% <0.00%> (-0.20%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.14% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.00% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <0.00%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <0.00%> (ø)` | |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.86%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.29% -5.87%
==========================================
Files 917 810 -107
Lines 46130 40944 -5186
Branches 5600 4217 -1383
==========================================
- Hits 35595 29193 -6402
- Misses 10403 11751 +1348
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `?` | |
| python | `80.54% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| ... and [496 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.75%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.40% -5.76%
==========================================
Files 917 821 -96
Lines 46130 41006 -5124
Branches 5600 4227 -1373
==========================================
- Hits 35595 29282 -6313
- Misses 10403 11724 +1321
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.46% <89.36%> (+0.04%)` | :arrow_up: |
| postgres | `80.50% <89.36%> (+0.04%)` | :arrow_up: |
| presto | `80.17% <85.10%> (+0.04%)` | :arrow_up: |
| python | `80.73% <89.36%> (-0.23%)` | :arrow_down: |
| sqlite | `80.12% <82.97%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #13530:
URL: https://github.com/apache/superset/pull/13530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 77.09% -0.07%
==========================================
Files 917 917
Lines 46130 46130
Branches 5600 5517 -83
==========================================
- Hits 35595 35566 -29
- Misses 10403 10432 +29
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.06% <ø> (-0.02%)` | :arrow_down: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `?` | |
| python | `80.84% <ø> (-0.12%)` | :arrow_down: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <0.00%> (-5.99%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.90%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.26% -5.91%
==========================================
Files 917 810 -107
Lines 46130 40916 -5214
Branches 5600 4217 -1383
==========================================
- Hits 35595 29157 -6438
- Misses 10403 11759 +1356
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.43% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.48% <ø> (-0.48%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| ... and [507 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `0.35%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 77.51% +0.35%
==========================================
Files 917 942 +25
Lines 46130 49686 +3556
Branches 5600 5905 +305
==========================================
+ Hits 35595 38516 +2921
- Misses 10403 11038 +635
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.75% <ø> (+0.30%)` | :arrow_up: |
| hive | `80.58% <ø> (+0.50%)` | :arrow_up: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `81.28% <ø> (+0.82%)` | :arrow_up: |
| presto | `80.12% <ø> (ø)` | |
| python | `81.83% <ø> (+0.87%)` | :arrow_up: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `68.57% <0.00%> (-27.43%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `84.00% <0.00%> (-16.00%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `18.27% <0.00%> (-9.73%)` | :arrow_down: |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `24.24% <0.00%> (-9.10%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `52.17% <0.00%> (-7.83%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `36.66% <0.00%> (-7.78%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.46% <0.00%> (-7.11%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `89.21% <0.00%> (-3.65%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `91.20% <0.00%> (-3.53%)` | :arrow_down: |
| [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `85.07% <0.00%> (-2.69%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `0.22%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 76.93% -0.23%
==========================================
Files 917 917
Lines 46130 46130
Branches 5600 5517 -83
==========================================
- Hits 35595 35492 -103
- Misses 10403 10506 +103
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `?` | |
| python | `80.54% <ø> (-0.42%)` | :arrow_down: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engines/hive.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lcy9oaXZlLnB5) | `0.00% <0.00%> (-85.72%)` | :arrow_down: |
| [superset/db\_engine\_specs/hive.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2hpdmUucHk=) | `74.23% <0.00%> (-16.54%)` | :arrow_down: |
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `81.62% <0.00%> (-6.84%)` | :arrow_down: |
| [superset/views/database/mixins.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvbWl4aW5zLnB5) | `81.03% <0.00%> (-1.73%)` | :arrow_down: |
| [superset/db\_engine\_specs/base.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2Jhc2UucHk=) | `85.57% <0.00%> (-0.49%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian commented on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
suddjian commented on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-808559640
Closing because I believe this case is already covered by other dashboard tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.86%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.29% -5.87%
==========================================
Files 917 821 -96
Lines 46130 41006 -5124
Branches 5600 4227 -1373
==========================================
- Hits 35595 29235 -6360
- Misses 10403 11771 +1368
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.50% <89.36%> (+0.04%)` | :arrow_up: |
| presto | `?` | |
| python | `80.54% <89.36%> (-0.42%)` | :arrow_down: |
| sqlite | `80.12% <82.97%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [546 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.75%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.40% -5.76%
==========================================
Files 917 821 -96
Lines 46130 41006 -5124
Branches 5600 4227 -1373
==========================================
- Hits 35595 29282 -6313
- Misses 10403 11724 +1321
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.46% <89.36%> (+0.04%)` | :arrow_up: |
| postgres | `80.50% <89.36%> (+0.04%)` | :arrow_up: |
| presto | `80.17% <85.10%> (+0.04%)` | :arrow_up: |
| python | `80.73% <89.36%> (-0.23%)` | :arrow_down: |
| sqlite | `80.12% <82.97%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [540 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `0.68%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 77.84% +0.68%
==========================================
Files 917 920 +3
Lines 46130 48692 +2562
Branches 5600 5517 -83
==========================================
+ Hits 35595 37906 +2311
- Misses 10403 10654 +251
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.58% <ø> (+0.50%)` | :arrow_up: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `81.28% <ø> (+0.82%)` | :arrow_up: |
| presto | `80.12% <ø> (ø)` | |
| python | `81.83% <ø> (+0.87%)` | :arrow_up: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `86.58% <0.00%> (-1.89%)` | :arrow_down: |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | `97.77% <0.00%> (-0.57%)` | :arrow_down: |
| [superset/sql\_parse.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX3BhcnNlLnB5) | `99.19% <0.00%> (-0.20%)` | :arrow_down: |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.14% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/db\_engine\_specs/postgres.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Bvc3RncmVzLnB5) | `96.00% <0.00%> (-0.06%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <0.00%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <0.00%> (ø)` | |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <0.00%> (ø)` | |
| ... and [14 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.90%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.25% -5.91%
==========================================
Files 917 821 -96
Lines 46130 40978 -5152
Branches 5600 4227 -1373
==========================================
- Hits 35595 29198 -6397
- Misses 10403 11780 +1377
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.48% <89.36%> (+0.02%)` | :arrow_up: |
| presto | `?` | |
| python | `80.48% <89.36%> (-0.48%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [556 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
=======================================
Coverage 77.16% 77.16%
=======================================
Files 917 917
Lines 46130 46130
Branches 5600 5517 -83
=======================================
Hits 35595 35595
Misses 10403 10403
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.08% <ø> (ø)` | |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `80.12% <ø> (ø)` | |
| python | `80.96% <ø> (ø)` | |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `0.06%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 77.09% -0.07%
==========================================
Files 917 917
Lines 46130 46130
Branches 5600 5517 -83
==========================================
- Hits 35595 35566 -29
- Misses 10403 10432 +29
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.08% <ø> (ø)` | |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `?` | |
| python | `80.84% <ø> (-0.12%)` | :arrow_down: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `82.47% <0.00%> (-5.99%)` | :arrow_down: |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | `88.55% <0.00%> (-0.28%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.93%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.23% -5.94%
==========================================
Files 917 810 -107
Lines 46130 40916 -5214
Branches 5600 4217 -1383
==========================================
- Hits 35595 29145 -6450
- Misses 10403 11771 +1368
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `?` | |
| postgres | `80.43% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.43% <ø> (-0.53%)` | :arrow_down: |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| ... and [509 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `0.37%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 77.53% +0.37%
==========================================
Files 917 942 +25
Lines 46130 49686 +3556
Branches 5600 5905 +305
==========================================
+ Hits 35595 38526 +2931
- Misses 10403 11028 +625
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.75% <ø> (+0.30%)` | :arrow_up: |
| hive | `81.04% <ø> (+0.95%)` | :arrow_up: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `81.28% <ø> (+0.82%)` | :arrow_up: |
| presto | `80.12% <ø> (ø)` | |
| python | `81.87% <ø> (+0.90%)` | :arrow_up: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...ntend/src/explore/controlUtils/getControlConfig.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29udHJvbFV0aWxzL2dldENvbnRyb2xDb25maWcudHM=) | `68.57% <0.00%> (-27.43%)` | :arrow_down: |
| [superset-frontend/src/filters/utils.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvdXRpbHMudHM=) | `84.00% <0.00%> (-16.00%)` | :arrow_down: |
| [.../nativeFilters/FilterBar/FilterSets/FilterSets.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyU2V0cy50c3g=) | `18.27% <0.00%> (-9.73%)` | :arrow_down: |
| [...onents/nativeFilters/FilterBar/FilterSets/utils.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvdXRpbHMudHM=) | `24.24% <0.00%> (-9.10%)` | :arrow_down: |
| [...ents/nativeFilters/FilterBar/FilterSets/Footer.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRm9vdGVyLnRzeA==) | `52.17% <0.00%> (-7.83%)` | :arrow_down: |
| [...tiveFilters/FilterBar/FilterSets/FiltersHeader.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyQmFyL0ZpbHRlclNldHMvRmlsdGVyc0hlYWRlci50c3g=) | `36.66% <0.00%> (-7.78%)` | :arrow_down: |
| [...et-frontend/src/dashboard/actions/nativeFilters.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9hY3Rpb25zL25hdGl2ZUZpbHRlcnMudHM=) | `60.46% <0.00%> (-7.11%)` | :arrow_down: |
| [...onfigModal/FiltersConfigForm/FiltersConfigForm.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlcnNDb25maWdGb3JtLnRzeA==) | `89.21% <0.00%> (-3.65%)` | :arrow_down: |
| [...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9NZXRyaWNDb250cm9sL0FkaG9jTWV0cmljUG9wb3ZlclRyaWdnZXIudHN4) | `91.20% <0.00%> (-3.53%)` | :arrow_down: |
| [...t-frontend/src/components/AsyncAceEditor/index.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQXN5bmNBY2VFZGl0b3IvaW5kZXgudHN4) | `85.07% <0.00%> (-2.69%)` | :arrow_down: |
| ... and [67 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] suddjian closed pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
suddjian closed pull request #13530:
URL: https://github.com/apache/superset/pull/13530
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (d2ebbc0) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.84%`.
> The diff coverage is `79.62%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.32% -5.85%
==========================================
Files 917 821 -96
Lines 46130 41006 -5124
Branches 5600 4227 -1373
==========================================
- Hits 35595 29246 -6349
- Misses 10403 11760 +1357
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <72.13%> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.46% <89.36%> (+0.04%)` | :arrow_up: |
| postgres | `80.50% <89.36%> (+0.04%)` | :arrow_up: |
| presto | `?` | |
| python | `80.58% <89.36%> (-0.38%)` | :arrow_down: |
| sqlite | `80.12% <82.97%> (+0.04%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...tersConfigModal/FiltersConfigForm/ControlItems.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0NvbnRyb2xJdGVtcy50c3g=) | `64.28% <ø> (-0.94%)` | :arrow_down: |
| [...rontend/src/filters/components/Range/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9idWlsZFF1ZXJ5LnRz) | `0.00% <ø> (ø)` | |
| [...set-frontend/src/filters/components/Range/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9SYW5nZS9pbmRleC50cw==) | `75.00% <ø> (+45.00%)` | :arrow_up: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `100.00% <ø> (+33.33%)` | :arrow_up: |
| [...et-frontend/src/filters/components/Select/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvaW5kZXgudHM=) | `100.00% <ø> (+60.00%)` | :arrow_up: |
| [...rset-frontend/src/filters/components/Time/index.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lL2luZGV4LnRz) | `75.00% <ø> (+41.66%)` | :arrow_up: |
| [...nd/src/filters/components/TimeColumn/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL2J1aWxkUXVlcnkudHM=) | `0.00% <0.00%> (ø)` | |
| [...rc/filters/components/TimeColumn/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lQ29sdW1uL3RyYW5zZm9ybVByb3BzLnRz) | `0.00% <0.00%> (ø)` | |
| [...end/src/filters/components/TimeGrain/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (ø)` | |
| [...src/filters/components/TimeGrain/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9UaW1lR3JhaW4vdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (ø)` | |
| ... and [544 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **decrease** coverage by `5.87%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
- Coverage 77.16% 71.28% -5.88%
==========================================
Files 917 810 -107
Lines 46130 40916 -5214
Branches 5600 4217 -1383
==========================================
- Hits 35595 29166 -6429
- Misses 10403 11750 +1347
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `?` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.43% <ø> (-0.02%)` | :arrow_down: |
| presto | `?` | |
| python | `80.52% <ø> (-0.44%)` | :arrow_down: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...uperset-frontend/src/dashboard/util/dnd-reorder.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2RuZC1yZW9yZGVyLmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rset-frontend/src/dashboard/util/getEmptyLayout.js](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC91dGlsL2dldEVtcHR5TGF5b3V0Lmpz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...et-frontend/src/components/Pagination/Ellipsis.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvUGFnaW5hdGlvbi9FbGxpcHNpcy50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...-frontend/src/components/OmniContainer/Omnibar.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvT21uaUNvbnRhaW5lci9PbW5pYmFyLnRzeA==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...frontend/src/components/ErrorMessage/IssueCode.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0lzc3VlQ29kZS50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...rc/components/ErrorMessage/TimeoutErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL1RpbWVvdXRFcnJvck1lc3NhZ2UudHN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...dashboard/components/resizable/ResizableHandle.jsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL3Jlc2l6YWJsZS9SZXNpemFibGVIYW5kbGUuanN4) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...tersConfigModal/Footer/CancelConfirmationAlert.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0Zvb3Rlci9DYW5jZWxDb25maXJtYXRpb25BbGVydC50c3g=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ConfigModal/FiltersConfigForm/FilterScope/state.ts](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0ZpbHRlclNjb3BlL3N0YXRlLnRz) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...c/components/ErrorMessage/DatabaseErrorMessage.tsx](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvRXJyb3JNZXNzYWdlL0RhdGFiYXNlRXJyb3JNZXNzYWdlLnRzeA==) | `0.00% <0.00%> (-94.74%)` | :arrow_down: |
| ... and [504 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test no access to charts when no access to dashboard
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (9798460) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `3.70%`.
> The diff coverage is `77.34%`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 80.86% +3.70%
==========================================
Files 917 304 -613
Lines 46130 24812 -21318
Branches 5600 0 -5600
==========================================
- Hits 35595 20064 -15531
+ Misses 10403 4748 -5655
+ Partials 132 0 -132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `?` | |
| hive | `80.05% <76.73%> (-0.04%)` | :arrow_down: |
| javascript | `?` | |
| mysql | `80.35% <75.83%> (-0.07%)` | :arrow_down: |
| postgres | `?` | |
| presto | `80.08% <76.73%> (-0.05%)` | :arrow_down: |
| python | `80.86% <77.34%> (-0.10%)` | :arrow_down: |
| sqlite | `80.02% <74.92%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/constants.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uc3RhbnRzLnB5) | `100.00% <ø> (ø)` | |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | `100.00% <ø> (ø)` | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `75.55% <0.00%> (ø)` | |
| [superset/cli.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2xpLnB5) | `33.66% <20.00%> (-0.09%)` | :arrow_down: |
| [superset/utils/data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvZGF0YS5weQ==) | `27.94% <27.94%> (ø)` | |
| [superset/examples/big\_data.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlnX2RhdGEucHk=) | `33.33% <33.33%> (ø)` | |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `81.99% <50.00%> (-0.08%)` | :arrow_down: |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `92.15% <80.00%> (+0.32%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `90.63% <83.33%> (+0.08%)` | :arrow_up: |
| [superset/db\_engine\_specs/crate.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2NyYXRlLnB5) | `92.30% <92.30%> (ø)` | |
| ... and [576 more](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] amitmiran137 closed pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
amitmiran137 closed pull request #13530:
URL: https://github.com/apache/superset/pull/13530
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794029613
# [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=h1) Report
> Merging [#13530](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=desc) (4fb6a20) into [master](https://codecov.io/gh/apache/superset/commit/9b8e2555bf66efe6fdbfb308866d88d86cec2d5b?el=desc) (9b8e255) will **increase** coverage by `0.31%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13530 +/- ##
==========================================
+ Coverage 77.16% 77.47% +0.31%
==========================================
Files 917 917
Lines 46130 46823 +693
Branches 5600 5517 -83
==========================================
+ Hits 35595 36276 +681
- Misses 10403 10415 +12
Partials 132 132
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `57.45% <ø> (+<0.01%)` | :arrow_up: |
| hive | `80.58% <ø> (+0.50%)` | :arrow_up: |
| javascript | `62.80% <ø> (ø)` | |
| mysql | `80.41% <ø> (ø)` | |
| postgres | `80.45% <ø> (ø)` | |
| presto | `80.12% <ø> (ø)` | |
| python | `81.43% <ø> (+0.47%)` | :arrow_up: |
| sqlite | `80.07% <ø> (ø)` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | `90.14% <0.00%> (-0.14%)` | :arrow_down: |
| [superset/charts/schemas.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL3NjaGVtYXMucHk=) | `100.00% <0.00%> (ø)` | |
| [superset/databases/commands/create.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL2NyZWF0ZS5weQ==) | `91.93% <0.00%> (+0.09%)` | :arrow_up: |
| [superset/utils/log.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvbG9nLnB5) | `94.91% <0.00%> (+0.93%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `92.22% <0.00%> (+1.67%)` | :arrow_up: |
| [superset/connectors/druid/models.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9kcnVpZC9tb2RlbHMucHk=) | `84.25% <0.00%> (+2.18%)` | :arrow_up: |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | `90.70% <0.00%> (+2.27%)` | :arrow_up: |
| [superset/databases/commands/test\_connection.py](https://codecov.io/gh/apache/superset/pull/13530/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2NvbW1hbmRzL3Rlc3RfY29ubmVjdGlvbi5weQ==) | `91.66% <0.00%> (+2.53%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=footer). Last update [9b8e255...4fb6a20](https://codecov.io/gh/apache/superset/pull/13530?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on pull request #13530: chore(dashboard_rbac): test get charts access
Posted by GitBox <gi...@apache.org>.
junlincc commented on pull request #13530:
URL: https://github.com/apache/superset/pull/13530#issuecomment-794566315
@amitmiran137 Appreciate your PR! would you mind adding a few lines in the description? 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org