You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "Clebert Suconic (Jira)" <ji...@apache.org> on 2021/09/13 20:26:00 UTC
[jira] [Closed] (ARTEMIS-3475) Possible recursion on
PacketImpl::toString
[ https://issues.apache.org/jira/browse/ARTEMIS-3475?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Clebert Suconic closed ARTEMIS-3475.
------------------------------------
Resolution: Fixed
> Possible recursion on PacketImpl::toString
> ------------------------------------------
>
> Key: ARTEMIS-3475
> URL: https://issues.apache.org/jira/browse/ARTEMIS-3475
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Reporter: Clebert Suconic
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is a mix of a bug and a task...
> classes extending Packet on core client are using a method named getParentString() on the toString();
> The initial intent was to be simple and never to abuse inheritance on the getParentString();
> Recent iteration on the code added a few occasions with toString() calling getParentString() calling toString() what caused a recursive loop.
> I'm making this simpler. by introducing a getPacketString() on PacketImpl where every extension of PacketImpl to simply call super.getParentString();
> Even though it still possible for someone to call itself on getParentString(), at least it would be clearer and easier to catch on revisions.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)