You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@calcite.apache.org by GitBox <gi...@apache.org> on 2019/07/15 11:00:35 UTC

[GitHub] [calcite] jinxing64 commented on a change in pull request #1318: [CALCITE-3196] In Frameworks, add BasePrepareAction (a functional int…

jinxing64 commented on a change in pull request #1318: [CALCITE-3196] In Frameworks, add BasePrepareAction (a functional int…
URL: https://github.com/apache/calcite/pull/1318#discussion_r303381355
 
 

 ##########
 File path: core/src/main/java/org/apache/calcite/tools/Frameworks.java
 ##########
 @@ -143,19 +155,33 @@ public R apply(RelOptCluster cluster, RelOptSchema relOptSchema,
    * @param action Callback containing user-specified code
    * @return Return value from action
    */
-  public static <R> R withPrepare(PrepareAction<R> action) {
+  public static <R> R withPrepare(BasePrepareAction<R> action) {
 
 Review comment:
   I'm ok with this change and just notice that `action` will run with the "default" `FrameworkConfig` with this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services