[jira] [Commented] (SSHD-759) Should not overwrite existing ssh key if the algorithm does not match

["Christian Schneider (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SSHD-759?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16109743#comment-16109743 ] 

Christian Schneider commented on SSHD-759:
------------------------------------------

What is the recommended way to provide reading keys as well as automatic key generation?

> Should not overwrite existing ssh key if the algorithm does not match
> ---------------------------------------------------------------------
>
>                 Key: SSHD-759
>                 URL: https://issues.apache.org/jira/browse/SSHD-759
>             Project: MINA SSHD
>          Issue Type: Bug
>    Affects Versions: 1.4.0
>            Reporter: Christian Schneider
>
> Currently a key file that does not have the correct algorithm is simply deleted.
> I think this is not a good behaviour as the user might have created the key explicitly.
> https://github.com/apache/mina-sshd/blob/master/sshd-core/src/main/java/org/apache/sshd/server/keyprovider/AbstractGeneratorHostKeyProvider.java#L238-L244
> I propose we simply throw an exception if the algorithm does not match. Then the user can decide if he wants to delete the file or change the algorithm.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)