You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/04/26 13:33:21 UTC

[GitHub] [flink] zentol commented on a diff in pull request #19528: [FLINK-27228][ci] Redistributed modules across CI profiles

zentol commented on code in PR #19528:
URL: https://github.com/apache/flink/pull/19528#discussion_r858719635


##########
tools/ci/stage.sh:
##########
@@ -21,8 +21,8 @@ STAGE_COMPILE="compile"
 STAGE_CORE="core"
 STAGE_PYTHON="python"
 STAGE_TABLE="table"
-STAGE_CONNECTORS="connectors"
-STAGE_KAFKA_GELLY="kafka/gelly"
+STAGE_CONNECTORS_1="connectors_1"
+STAGE_CONNECTORS_2="connectors_2"

Review Comment:
   any suggestions? there isn't a particular pattern (apart from formats/reporters/filesystems being in connector_1), and I'm not keen on a naming scheme that includes specific modules (e.g., "kafka/pulsar") as I'm not keen on having to rename stuff when we externalize more stuff.
   
   Ultimately the lifetime of these stages is limited anyway; until the connectors have been externalized,



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org