You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@activemq.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2018/01/22 21:03:00 UTC
[jira] [Commented] (ARTEMIS-609) Documentation for Interceptors is
wrong regarding broker.xml file structure
[ https://issues.apache.org/jira/browse/ARTEMIS-609?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16334893#comment-16334893 ]
ASF GitHub Bot commented on ARTEMIS-609:
----------------------------------------
GitHub user jbertram opened a pull request:
https://github.com/apache/activemq-artemis/pull/1805
ARTEMIS-609 fix interceptor XML docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jbertram/activemq-artemis ARTEMIS-609
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/1805.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1805
----
commit e3561fde13d0cb05fb5c58fe7cca7843defa11de
Author: Justin Bertram <jb...@...>
Date: 2018-01-22T21:01:04Z
ARTEMIS-609 fix interceptor XML docs
----
> Documentation for Interceptors is wrong regarding broker.xml file structure
> ---------------------------------------------------------------------------
>
> Key: ARTEMIS-609
> URL: https://issues.apache.org/jira/browse/ARTEMIS-609
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Affects Versions: 1.3.0
> Reporter: Jiri Daněk
> Assignee: Justin Bertram
> Priority: Major
> Labels: documentation
>
> Documentation suggests that the {{<remoting-incoming-interceptors>}} element is a direct children of the {{<configuration>}} element. In fact, it must be children of the {{<core>}} element, the way it is done in {{examples/features/standard/interceptor/src/main/resources/activemq/server0/broker.xml}}.
> This issue is present in the following files
> * {{docs/user-manual/en/intercepting-operations.md}}
> * {{examples/features/standard/interceptor/readme.html}}
> * {{examples/features/standard/interceptor-client/readme.html}}
> I worry that these obsolete configuration fragments are remnants of some past change in the {{broker.xml}} file structure and that there could be more to be found.
> One more thing. The last two files in my list have completely the same content. Is that really intentional?
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)