You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by daserge <gi...@git.apache.org> on 2016/02/17 12:48:55 UTC
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
GitHub user daserge opened a pull request:
https://github.com/apache/cordova-plugin-device/pull/50
CB-10636 Add JSHint for plugins
Added Travis badge
Added node_modules to gitignore
Disabled quotmark as it is [deprecated](http://jshint.com/docs/options/#quotmark)
Fixed jshint issues
[Jira issue](https://issues.apache.org/jira/browse/CB-10636)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/daserge/cordova-plugin-device CB-10636
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device/pull/50.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #50
----
commit cde432a78f3ec23992438d090efdc9f6ad6f01d8
Author: daserge <v-...@microsoft.com>
Date: 2016-02-17T11:41:14Z
CB-10636 Add JSHint for plugins
Added Travis badge
Added node_modules to gitignore
Disabled quotmark as it is deprecated
Fixed jshint issues
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185276032
I think this is because of https://developer.mozilla.org/docs/Web/API/Window/name
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cordova-plugin-device/pull/50
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185169590
There is one issue remaining:
https://github.com/apache/cordova-plugin-device/blob/52f0b41d841238659d7c7f32d60d9231718b27ac/src/ubuntu/device.js#L28
`src\ubuntu\device.js: line 27, col 24, 'name' is not defined.`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53170790
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+ "node": true
--- End diff --
Should't we use `browser: true` instead and add `define`, `module` and `require` to `globals`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by vladimir-kotikov <gi...@git.apache.org>.
Github user vladimir-kotikov commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53171195
--- Diff: .jshintrc ---
@@ -0,0 +1,16 @@
+{
+ "node": true
+ , "bitwise": true
+ , "undef": true
+ , "trailing": true
+ , "quotmark": false
+ , "indent": 4
+ , "unused": "vars"
+ , "latedef": "nofunc"
+ , "jasmine": true
--- End diff --
Setting `jasmine` here seems excess, as there is only one file with tests. Maybe just add inline `/* jshint jasmine: true*/` to `tests.js`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by nikhilkh <gi...@git.apache.org>.
Github user nikhilkh commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53258984
--- Diff: .travis.yml ---
@@ -0,0 +1,6 @@
+language: node_js
+sudo: false
+node_js:
+ - "0.10"
--- End diff --
There is no point in running jshint for all 3 versions of node.js.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185571218
@nikhilkh, @dblotsky, addressed, thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by dblotsky <gi...@git.apache.org>.
Github user dblotsky commented on a diff in the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#discussion_r53259132
--- Diff: .travis.yml ---
@@ -0,0 +1,6 @@
+language: node_js
+sudo: false
+node_js:
+ - "0.10"
+ - "0.12"
+ - "4.2"
--- End diff --
We don't need to test on different Node versions, since there is no Node code in plugins.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185169780
@vladimir-kotikov, could you please take a look?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-device pull request: CB-10636 Add JSHint for plugin...
Posted by daserge <gi...@git.apache.org>.
Github user daserge commented on the pull request:
https://github.com/apache/cordova-plugin-device/pull/50#issuecomment-185273857
Addressed, thanks for review, @vladimir-kotikov.
BTW, jshint does not highlight the `src\ubuntu\device.js: line 27, col 24, 'name' is not defined.` issue with `browser: true` setting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org