You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2020/07/23 08:16:30 UTC

[GitHub] [incubator-doris] wutiangan commented on a change in pull request #4158: [RoutineLoad] Support modify routine load job

wutiangan commented on a change in pull request #4158:
URL: https://github.com/apache/incubator-doris/pull/4158#discussion_r459284714



##########
File path: fe/fe-core/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -602,6 +573,24 @@ public void replayChangeRoutineLoadJob(RoutineLoadOperation operation) {
                  .add("msg", "replay change routine load job")
                  .build());
     }
+    
+    /**
+     * Enter of altering a routine load job
+     */
+    public void alterRoutineLoadJob(AlterRoutineLoadStmt stmt) throws UserException {
+        RoutineLoadJob job = checkPrivAndGetJob(stmt.getDbName(), stmt.getLabel());
+        if (stmt.hasDataSourceProperty()
+                && !stmt.getDataSourceProperties().getType().equalsIgnoreCase(job.dataSourceType.name())) {
+            throw new DdlException("The spciefied job type is not: " + stmt.getDataSourceProperties().getType());

Review comment:
       ‘spciefied’ Wrong characters




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org